From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E610CA0613 for ; Thu, 26 Sep 2019 15:43:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A5ADB5B32; Thu, 26 Sep 2019 15:43:36 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id DE28D4C90 for ; Thu, 26 Sep 2019 15:43:34 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Sep 2019 06:43:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,552,1559545200"; d="scan'208";a="190007421" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by fmsmga007.fm.intel.com with ESMTP; 26 Sep 2019 06:43:32 -0700 Date: Thu, 26 Sep 2019 21:41:18 +0800 From: Ye Xiaolong To: Haiyue Wang Cc: dev@dpdk.org, ferruh.yigit@intel.com, ray.kinsella@intel.com, bernard.iremonger@intel.com, chenmin.sun@intel.com Message-ID: <20190926134118.GA91335@intel.com> References: <20190926114818.91063-1-haiyue.wang@intel.com> <20190926114818.91063-2-haiyue.wang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190926114818.91063-2-haiyue.wang@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v1 1/4] ethdev: add the API for getting burst mode information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 09/26, Haiyue Wang wrote: >Some PMDs have more than one RX/TX burst paths, add the ethdev API >that allows an application to retrieve the mode information about >Rx/Tx packet burst such as Scalar or Vector, and Vector technology >like AVX2. > >Signed-off-by: Haiyue Wang >Acked-by: Bernard Iremonger >--- > doc/guides/rel_notes/release_19_11.rst | 9 +++ > lib/librte_ethdev/rte_ethdev.c | 75 ++++++++++++++++++++++ > lib/librte_ethdev/rte_ethdev.h | 82 ++++++++++++++++++++++++ > lib/librte_ethdev/rte_ethdev_core.h | 5 ++ > lib/librte_ethdev/rte_ethdev_version.map | 5 ++ > 5 files changed, 176 insertions(+) > [snip] >+typedef void (*eth_burst_mode_get_t)(struct rte_eth_dev *dev, >+ uint16_t queue_id, struct rte_eth_burst_mode *mode); >+ There is ongoing effort to change the return type of dev_ops callback from void to int, like [1] Better to keep align with it. [1] http://patchwork.dpdk.org/project/dpdk/list/?series=6391 Thanks, Xiaolong > typedef int (*mtu_set_t)(struct rte_eth_dev *dev, uint16_t mtu); > /**< @internal Set MTU. */ > >@@ -542,6 +545,8 @@ struct eth_dev_ops { > eth_dev_infos_get_t dev_infos_get; /**< Get device info. */ > eth_rxq_info_get_t rxq_info_get; /**< retrieve RX queue information. */ > eth_txq_info_get_t txq_info_get; /**< retrieve TX queue information. */ >+ eth_burst_mode_get_t rx_burst_mode_get; /**< Get RX burst mode */ >+ eth_burst_mode_get_t tx_burst_mode_get; /**< Get TX burst mode */ > eth_fw_version_get_t fw_version_get; /**< Get firmware version. */ > eth_dev_supported_ptypes_get_t dev_supported_ptypes_get; > /**< Get packet types supported and identified by device. */ >diff --git a/lib/librte_ethdev/rte_ethdev_version.map b/lib/librte_ethdev/rte_ethdev_version.map >index 6df42a47b..e59d51648 100644 >--- a/lib/librte_ethdev/rte_ethdev_version.map >+++ b/lib/librte_ethdev/rte_ethdev_version.map >@@ -283,4 +283,9 @@ EXPERIMENTAL { > > # added in 19.08 > rte_eth_read_clock; >+ >+ # added in 19.11 >+ rte_eth_rx_burst_mode_get; >+ rte_eth_tx_burst_mode_get; >+ rte_eth_burst_mode_option_name; > }; >-- >2.17.1 >