From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1050EA0613 for ; Fri, 27 Sep 2019 05:18:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D2F5E2C37; Fri, 27 Sep 2019 05:18:16 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 2BA7E23D for ; Fri, 27 Sep 2019 05:18:02 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Sep 2019 20:18:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,553,1559545200"; d="scan'208";a="389832913" Received: from npg-dpdk-cvl-yingwang-117d84.sh.intel.com ([10.67.117.96]) by fmsmga005.fm.intel.com with ESMTP; 26 Sep 2019 20:18:01 -0700 From: Ying Wang To: xiaolong.ye@intel.com, qi.z.zhang@intel.com Cc: dev@dpdk.org, qiming.yang@intel.com, wei.zhao1@intel.com, ying.a.wang@intel.com Date: Fri, 27 Sep 2019 02:55:20 +0800 Message-Id: <20190926185524.317595-2-ying.a.wang@intel.com> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20190926185524.317595-1-ying.a.wang@intel.com> References: <20190916230615.411726-2-ying.a.wang@intel.com> <20190926185524.317595-1-ying.a.wang@intel.com> Subject: [dpdk-dev] [PATCH v3 1/5] net/ice: minor code clean X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The patch removes redundant code and cleans up some wrong indentations. Signed-off-by: Ying Wang --- drivers/net/ice/ice_generic_flow.c | 39 +++++++++++++++++++------------------- 1 file changed, 19 insertions(+), 20 deletions(-) diff --git a/drivers/net/ice/ice_generic_flow.c b/drivers/net/ice/ice_generic_flow.c index 1c0adc779..44dbccd3d 100644 --- a/drivers/net/ice/ice_generic_flow.c +++ b/drivers/net/ice/ice_generic_flow.c @@ -44,21 +44,21 @@ const struct rte_flow_ops ice_flow_ops = { static int ice_flow_valid_attr(const struct rte_flow_attr *attr, - struct rte_flow_error *error) + struct rte_flow_error *error) { /* Must be input direction */ if (!attr->ingress) { rte_flow_error_set(error, EINVAL, - RTE_FLOW_ERROR_TYPE_ATTR_INGRESS, - attr, "Only support ingress."); + RTE_FLOW_ERROR_TYPE_ATTR_INGRESS, + attr, "Only support ingress."); return -rte_errno; } /* Not supported */ if (attr->egress) { rte_flow_error_set(error, EINVAL, - RTE_FLOW_ERROR_TYPE_ATTR_EGRESS, - attr, "Not support egress."); + RTE_FLOW_ERROR_TYPE_ATTR_EGRESS, + attr, "Not support egress."); return -rte_errno; } @@ -73,8 +73,8 @@ ice_flow_valid_attr(const struct rte_flow_attr *attr, /* Not supported */ if (attr->group) { rte_flow_error_set(error, EINVAL, - RTE_FLOW_ERROR_TYPE_ATTR_GROUP, - attr, "Not support group."); + RTE_FLOW_ERROR_TYPE_ATTR_GROUP, + attr, "Not support group."); return -rte_errno; } @@ -102,7 +102,7 @@ ice_find_first_item(const struct rte_flow_item *item, bool is_void) /* Skip all VOID items of the pattern */ static void ice_pattern_skip_void_item(struct rte_flow_item *items, - const struct rte_flow_item *pattern) + const struct rte_flow_item *pattern) { uint32_t cpy_count = 0; const struct rte_flow_item *pb = pattern, *pe = pattern; @@ -124,7 +124,6 @@ ice_pattern_skip_void_item(struct rte_flow_item *items, items += cpy_count; if (pe->type == RTE_FLOW_ITEM_TYPE_END) { - pb = pe; break; } @@ -560,10 +559,10 @@ static int ice_flow_valid_action(struct rte_eth_dev *dev, static int ice_flow_validate(struct rte_eth_dev *dev, - const struct rte_flow_attr *attr, - const struct rte_flow_item pattern[], - const struct rte_flow_action actions[], - struct rte_flow_error *error) + const struct rte_flow_attr *attr, + const struct rte_flow_item pattern[], + const struct rte_flow_action actions[], + struct rte_flow_error *error) { uint64_t inset = 0; int ret = ICE_ERR_NOT_SUPPORTED; @@ -609,10 +608,10 @@ ice_flow_validate(struct rte_eth_dev *dev, static struct rte_flow * ice_flow_create(struct rte_eth_dev *dev, - const struct rte_flow_attr *attr, - const struct rte_flow_item pattern[], - const struct rte_flow_action actions[], - struct rte_flow_error *error) + const struct rte_flow_attr *attr, + const struct rte_flow_item pattern[], + const struct rte_flow_action actions[], + struct rte_flow_error *error) { struct ice_pf *pf = ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private); struct rte_flow *flow = NULL; @@ -647,8 +646,8 @@ ice_flow_create(struct rte_eth_dev *dev, static int ice_flow_destroy(struct rte_eth_dev *dev, - struct rte_flow *flow, - struct rte_flow_error *error) + struct rte_flow *flow, + struct rte_flow_error *error) { struct ice_pf *pf = ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private); int ret = 0; @@ -669,7 +668,7 @@ ice_flow_destroy(struct rte_eth_dev *dev, static int ice_flow_flush(struct rte_eth_dev *dev, - struct rte_flow_error *error) + struct rte_flow_error *error) { struct ice_pf *pf = ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private); struct rte_flow *p_flow; -- 2.15.1