From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 573CFA0613 for ; Fri, 27 Sep 2019 12:09:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3319B1BEC9; Fri, 27 Sep 2019 12:09:01 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 56C7F1BE8E for ; Fri, 27 Sep 2019 12:08:59 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Sep 2019 03:08:58 -0700 X-IronPort-AV: E=Sophos;i="5.64,555,1559545200"; d="scan'208";a="219725469" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.95]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Sep 2019 03:08:56 -0700 Date: Fri, 27 Sep 2019 11:08:54 +0100 From: Bruce Richardson To: Marcin Baran Cc: dev@dpdk.org, Pawel Modrak Message-ID: <20190927100854.GD1847@bricha3-MOBL.ger.corp.intel.com> References: <20190919093850.460-1-marcinx.baran@intel.com> <20190920073714.1314-1-marcinx.baran@intel.com> <20190920073714.1314-5-marcinx.baran@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190920073714.1314-5-marcinx.baran@intel.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH v5 4/6] examples/ioat: add two threads configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Sep 20, 2019 at 09:37:12AM +0200, Marcin Baran wrote: > From: Pawel Modrak > > Added possibility to use two lcores: first for > packet receiving and copying, second for packets > sending. > > Signed-off-by: Pawel Modrak > Signed-off-by: Marcin Baran > --- > examples/ioat/ioatfwd.c | 92 ++++++++++++++++++++++++++++++----------- > 1 file changed, 67 insertions(+), 25 deletions(-) > > diff --git a/examples/ioat/ioatfwd.c b/examples/ioat/ioatfwd.c > index c66ce7e49..4c51db6bd 100644 > --- a/examples/ioat/ioatfwd.c > +++ b/examples/ioat/ioatfwd.c > @@ -161,7 +161,6 @@ ioat_enqueue_packets(struct rte_mbuf **pkts, > rte_mempool_put_bulk(ioat_pktmbuf_pool, (void *)&pkts_copy[i], > nb_rx - i); > > - > return ret; > } > > @@ -226,8 +225,8 @@ ioat_tx_port(struct rxtx_port_config *tx_config) > struct rte_mbuf *mbufs_dst[MAX_PKT_BURST]; > > if (copy_mode == COPY_MODE_IOAT_NUM) { > - /* Deque the mbufs from IOAT device. */ > for (i = 0; i < tx_config->nb_queues; i++) { > + /* Deque the mbufs from IOAT device. */ > nb_dq = rte_ioat_completed_copies( > tx_config->ioat_ids[i], MAX_PKT_BURST, > (void *)mbufs_src, (void *)mbufs_dst); > @@ -256,31 +255,64 @@ ioat_tx_port(struct rxtx_port_config *tx_config) > nb_dq - nb_tx); > } > } else { > - /* Deque the mbufs from rx_to_tx_ring. */ > - nb_dq = rte_ring_dequeue_burst(tx_config->rx_to_tx_ring, > - (void *)mbufs_dst, MAX_PKT_BURST, NULL); > - > - if (nb_dq == 0) > - return; > - > - /* Update macs if enabled */ > - if (mac_updating) { > - for (i = 0; i < nb_dq; i++) > - update_mac_addrs(mbufs_dst[i], > - tx_config->rxtx_port); > - } > + for (i = 0; i < tx_config->nb_queues; i++) { This commit refers to adding support for 2 threads rather than 1, but this change seems related to having multiple queues rather than threads. Shoudl it be in a previous patch? /Bruce