From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 34BC1A0613 for ; Fri, 27 Sep 2019 19:29:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 460571B9BF; Fri, 27 Sep 2019 19:29:40 +0200 (CEST) Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 6DDFC1B994 for ; Fri, 27 Sep 2019 19:29:39 +0200 (CEST) Received: by mail-pg1-f195.google.com with SMTP id z12so3844800pgp.9 for ; Fri, 27 Sep 2019 10:29:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8e16h2AlmfnCXbxvzPyt7kqDX/xESbYgiZ2u6GYMf44=; b=EJ+/Z7fHea4eHXGjc0S9Rox9EasklSzs4yPNTv1k5aTFxdi0jaCRXaLix/EhvHa+NT hoedarreM/HvqSo+yISPHL/wrozHsv9VYHe7gIVd1QW24dyHTCDhyJMW99VlNyxOwgtf b3mj8ksBB+qsj2hcNE6VFM7kGFoR8KfMUil5Yj7Cj11XHQxEJ+aPWkINBqQBTiWSVu0g Xw+PCqYa6GXS44uy2DUw0jvCW62ymPGqzB37U0W6XLVjZTsQhJvs20RW9VizhvGvinJe uyYxXFwtIRgqBfWOwv/OzvLwxxczC/ErHw/IvR4V1FrnUdmPpLMRJK2zrVrrqPAbktE0 OV7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8e16h2AlmfnCXbxvzPyt7kqDX/xESbYgiZ2u6GYMf44=; b=CdKgnrjbqs90YDAftS7YnQ1jHekZa0SP+DJBwy0lh+hfsnWTCTSfqQtAFh4JoxuTS+ hEv8SvajckDufyZu4crFG2Bi1+PfObSKPMJ5RDnzbnjr52cy6FXcpGsGDd9LAnjaNJwF q8twcZaog692jxlHzmEMDnxOKAJ2VGW/VWIKhtnNxz7F7wWtudS7dGT7hyKvZJo5RH8B fACEpR0Upjlf79R1+Q4IZsx3cShV7FBP2b09H5S5C4ukIfO3121KPg4DEosLHC7LLRwN qO3Ze/RWBg8A3OYgV2xN5iSiLwTfKX1lD1bL8DX8sR/qLjlv25CGyIESxPhJeihCB5yH XcVg== X-Gm-Message-State: APjAAAUJDzZTQuCilvCEZoG8uXXv6wKNkM1Wd7fyDSUxBR0KJkw5am0R a7Vm0HRcpjjW+FoVyFcLXLehlQ== X-Google-Smtp-Source: APXvYqzUeEt7iZQthr7rnqnW1vjO+zpwKtYDLbQM+yWV9vModgH9a6rerOGb4AxbFmiABBcD/eAumQ== X-Received: by 2002:aa7:8d8a:: with SMTP id i10mr5677452pfr.45.1569605378239; Fri, 27 Sep 2019 10:29:38 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id c10sm4802062pfo.49.2019.09.27.10.29.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Sep 2019 10:29:37 -0700 (PDT) Date: Fri, 27 Sep 2019 10:29:35 -0700 From: Stephen Hemminger To: Cc: , , Marko Kovacevic , Ori Kam , Bruce Richardson , Radu Nicolau , "Tomasz Kantecki" , Message-ID: <20190927102935.64e240c4@hermes.lan> In-Reply-To: <20190926100558.24348-10-pbhagavatula@marvell.com> References: <20190926100558.24348-1-pbhagavatula@marvell.com> <20190926100558.24348-10-pbhagavatula@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 09/11] examples/l3fwd: add event em main loop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 26 Sep 2019 15:35:56 +0530 wrote: > +#define L3FWD_EM_EVENT_MODE \ > +EM_FP(tx_d, 0, 0, L3FWD_EVENT_TX_DIRECT | L3FWD_EVENT_SINGLE) \ > +EM_FP(tx_d_burst, 0, 1, L3FWD_EVENT_TX_DIRECT | L3FWD_EVENT_BURST) \ > +EM_FP(tx_q, 1, 0, L3FWD_EVENT_TX_ENQ | L3FWD_EVENT_SINGLE) \ > +EM_FP(tx_q_burst, 1, 1, L3FWD_EVENT_TX_ENQ | L3FWD_EVENT_BURST) \ > + > +#define EM_FP(_name, _f2, _f1, flags) \ > +int \ > +em_event_main_loop_ ## _name(__attribute__((unused)) void *dummy); > +L3FWD_EM_EVENT_MODE > +#undef EM_FP Not a fan of this style of macro programming. First off, macros should be setup not take a semi-colon at the end. That is why checkpatch is grumbling about it. And it is quite opaque to know the result of this template. Why not just expand it as real code.