From: Konstantin Ananyev <konstantin.ananyev@intel.com>
To: dev@dpdk.org
Cc: michel@digirati.com.br, olivier.matz@6wind.com,
anatoly.burakov@intel.com, vipin.varghese@intel.com,
Konstantin Ananyev <konstantin.ananyev@intel.com>
Subject: [dpdk-dev] [PATCH v2 0/3] move mbuf definition into a separate file
Date: Fri, 27 Sep 2019 14:50:51 +0100 [thread overview]
Message-ID: <20190927135054.20845-1-konstantin.ananyev@intel.com> (raw)
In-Reply-To: <20190816125304.29719-1-konstantin.ananyev@intel.com>
v1 -> v2
As per Michel comments included <generic/rte_atomic.h> into rte_mbuf_core.h
Right now inclusion of rte_mbuf.h header can cause inclusion of
some arch/os specific headers.
That prevents it to be included directly by some
non-DPDK (but related) entities: KNI, BPF programs, etc.
To overcome that problem usually a separate definitions of rte_mbuf
structure is created within these entities.
That aproach has a lot of drawbacks: code duplication, error prone, etc.
This series moves rte_mbuf structure definition (and some related macros)
into a separate file that can be included by both rte_mbuf.h and
other non-DPDK entities.
Note that these moves shouldn't introduce any change for current DPDK code.
Konstantin Ananyev (3):
eal: move CACHE and IOVA related definitions
mbuf: move mbuf definition into a separate file
examples/bpf: remove duplicate mbuf definition
examples/bpf/t2.c | 4 +-
examples/bpf/t3.c | 2 +-
lib/librte_eal/common/include/rte_common.h | 44 ++
lib/librte_eal/common/include/rte_memory.h | 38 -
lib/librte_mbuf/Makefile | 5 +-
lib/librte_mbuf/meson.build | 3 +-
lib/librte_mbuf/rte_mbuf.h | 738 +-----------------
.../mbuf.h => lib/librte_mbuf/rte_mbuf_core.h | 558 ++++++++-----
8 files changed, 427 insertions(+), 965 deletions(-)
rename examples/bpf/mbuf.h => lib/librte_mbuf/rte_mbuf_core.h (51%)
--
2.17.1
next prev parent reply other threads:[~2019-09-27 13:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-16 12:53 [dpdk-dev] [PATCH " Konstantin Ananyev
2019-08-16 12:53 ` [dpdk-dev] [PATCH 1/3] eal: move CACHE and IOVA related definitions Konstantin Ananyev
2019-08-16 18:50 ` Michel Machado
2019-08-16 12:53 ` [dpdk-dev] [PATCH 2/3] mbuf: move mbuf definition into a separate file Konstantin Ananyev
2019-08-16 18:51 ` Michel Machado
2019-08-16 12:53 ` [dpdk-dev] [PATCH 3/3] examples/bpf: remove duplicate mbuf definition Konstantin Ananyev
2019-08-16 18:44 ` Michel Machado
2019-09-27 13:50 ` Konstantin Ananyev [this message]
2019-09-27 13:50 ` [dpdk-dev] [PATCH v2 1/3] eal: move CACHE and IOVA related definitions Konstantin Ananyev
2019-09-30 19:34 ` Michel Machado
2019-09-27 13:50 ` [dpdk-dev] [PATCH v2 2/3] mbuf: move mbuf definition into a separate file Konstantin Ananyev
2019-09-27 14:42 ` Andrew Rybchenko
2019-09-30 19:34 ` Michel Machado
2019-10-16 8:18 ` Olivier Matz
2019-09-27 13:50 ` [dpdk-dev] [PATCH v2 3/3] examples/bpf: remove duplicate mbuf definition Konstantin Ananyev
2019-09-30 19:35 ` Michel Machado
2019-10-25 20:33 ` [dpdk-dev] [PATCH v2 0/3] move mbuf definition into a separate file Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190927135054.20845-1-konstantin.ananyev@intel.com \
--to=konstantin.ananyev@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=michel@digirati.com.br \
--cc=olivier.matz@6wind.com \
--cc=vipin.varghese@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).