Re: [dpdk-dev] [PATCH 07/12] net/cxgbe: use dynamic logging for debug prints

[Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>]

On Friday, September 09/27/19, 2019 at 20:07:20 +0530, Ferruh Yigit wrote:
> On 9/6/2019 10:52 PM, Rahul Lakkireddy wrote:
> > Remove compile time flags and use dynamic logging for debug prints.
> > 
> > Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
> > ---
> >  config/common_base               |  5 ---
> >  doc/guides/nics/cxgbe.rst        | 20 -----------
> >  drivers/net/cxgbe/cxgbe_compat.h | 58 +++++++++++---------------------
> >  drivers/net/cxgbe/cxgbe_ethdev.c | 16 +++++++++
> >  4 files changed, 35 insertions(+), 64 deletions(-)
> > 
> > diff --git a/config/common_base b/config/common_base
> > index 8ef75c203..43964de6d 100644
> > --- a/config/common_base
> > +++ b/config/common_base
> > @@ -217,11 +217,6 @@ CONFIG_RTE_LIBRTE_BNXT_PMD=y
> >  # Compile burst-oriented Chelsio Terminator (CXGBE) PMD
> >  #
> >  CONFIG_RTE_LIBRTE_CXGBE_PMD=y
> > -CONFIG_RTE_LIBRTE_CXGBE_DEBUG=n
> 
> +1, thanks.
> 
> > -CONFIG_RTE_LIBRTE_CXGBE_DEBUG_REG=n
> > -CONFIG_RTE_LIBRTE_CXGBE_DEBUG_MBOX=n
> 
> Are above two used on datapath?
> 

MBOX is only used in control path. But, REG is used in both control
and datapath.

> > -CONFIG_RTE_LIBRTE_CXGBE_DEBUG_TX=n
> > -CONFIG_RTE_LIBRTE_CXGBE_DEBUG_RX=n
> 
> Are you sure about these?
> If these logs are enabled in datapath, switching to the dynamic log will add
> additional checks for logging, most probably per packet.

(Sigh)... You're correct! I was too excited about the nifty dynamic
log feature and somehow missed the above obvious point... :(

On second thought, the REG, TX, and RX prints are rarely enabled and
hence I'm going to remove them completely. OTOH, MBOX helped in
debugging several control path issues in the past, so it will be kept
as dynamic log.

Will send v2.

Thanks,
Rahul