From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57D77A0613 for ; Sat, 28 Sep 2019 02:38:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3A54C1B9B5; Sat, 28 Sep 2019 02:38:07 +0200 (CEST) Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by dpdk.org (Postfix) with ESMTP id F40C22C4F for ; Sat, 28 Sep 2019 02:38:03 +0200 (CEST) Received: by mail-pl1-f193.google.com with SMTP id s17so1684532plp.6 for ; Fri, 27 Sep 2019 17:38:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Q4INw0jXclEiki3qquDLRi7spTdZl6ftU0aD9i1ySi8=; b=jRiYQxjPWDwdvbmcAadyjKzeHVxUiL8r1f1b9uu6BQx87RihhSSMHNkVs1dK+fijbu suBysOFWBiMt3ikTjslfELulpdHaXCoIP3ozt8UG+HVYL9zxXYwthEUTjGF4vBYvpWZA YjQQOlK1BAK1BUPHFQ6ZQOqKa9ZZob1FEnZWUnAHuFmH3b75cmru4PyZWtYaogIJndU4 +M6rZwdHwwY7xAtwHEa9fQ+Ym8dnSZCMkWkb8ZFYESAwFptKGihDWuer/2dcX/kYcmMW CgLnNIlNbWnp4S5wlq4uEUO4fMjWUEJU6V6UeYlgOSO6u12XZBiay4IeT30plv/B3n4g L1zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Q4INw0jXclEiki3qquDLRi7spTdZl6ftU0aD9i1ySi8=; b=kyPx2vzY3nu9JCMjUPbwuGnyL4W2LzCsxPPMGCZAlNlEzTeSexNXyoo7WOjcJKXEJr xPO3g558mYI7OJQaT5oYr6L/fVwZUCnLbsBYjpyEa6VsXwq6oxREp3FxaKJmhyRr71Ft MG4K3eLfLNm0I7763UHo8/TzYIQNL6RXRIMEsICpeIoiCC8+BRjOXymNZVB2UdLJ5SAY ThgHmuTs8f6YdWzfcd9+gk+CfszM3LlMqrrUnBgKo2GekfvBRDWoSAco/MVLR7iDahiA QjbJ7JZKqoCSdAy6mFI086iAVUg3MGsRjBtQD8cwBfpgm9l9NVFZHWDBf/gsIJTKponx 8Drw== X-Gm-Message-State: APjAAAXt4DKr1n8ye24KeCdwC3WqGOx8kMhLPOJDJbHsqZ8xpSlP7pvs 3Oh2XlmHtFjbqfrGlW6PynBKP+WcxnM= X-Google-Smtp-Source: APXvYqwrVnGFXoCshKNBcioxvSoM7q+b/jPon8DcoUgOXCRyCQUd9e4NWXjoY+Mlh/WXozqnP3oqyg== X-Received: by 2002:a17:902:aa4a:: with SMTP id c10mr7556185plr.340.1569631082571; Fri, 27 Sep 2019 17:38:02 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id t13sm3494942pfh.12.2019.09.27.17.38.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Sep 2019 17:38:02 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Fri, 27 Sep 2019 17:37:54 -0700 Message-Id: <20190928003758.18489-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190928003758.18489-1-stephen@networkplumber.org> References: <20190928003758.18489-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 1/5] mbuf: don't generate invalid mbuf in clone test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The test for cloning changed mbuf would generate an mbuf whose length and segments were invalid. This would cause a crash if test was run with mbuf debugging enabled. Fixes: f1022aba76a5 ("app/test: rename mbuf variable") Signed-off-by: Stephen Hemminger --- app/test/test_mbuf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c index 2a97afe2044a..aafad0cf6206 100644 --- a/app/test/test_mbuf.c +++ b/app/test/test_mbuf.c @@ -332,8 +332,11 @@ testclone_testupdate_testdetach(struct rte_mempool *pktmbuf_pool) m->next = rte_pktmbuf_alloc(pktmbuf_pool); if (m->next == NULL) GOTO_FAIL("Next Pkt Null\n"); + m->nb_segs = 2; rte_pktmbuf_append(m->next, sizeof(uint32_t)); + m->pkt_len = 2 * sizeof(uint32_t); + data = rte_pktmbuf_mtod(m->next, unaligned_uint32_t *); *data = MAGIC_DATA; -- 2.20.1