From: Yasufumi Ogawa <yasufum.o@gmail.com>
To: Tetsuya Mukawa <mtetsuyah@gmail.com>
Cc: dev@dpdk.org, Yasufumi Ogawa <yasufum.o@gmail.com>
Subject: [dpdk-dev] [PATCH] net/null: fix multi-process rx and tx
Date: Sun, 29 Sep 2019 11:41:41 +0900 [thread overview]
Message-ID: <20190929024141.30443-1-yasufum.o@gmail.com> (raw)
Packet processing in secondary process cannot work because rx_pkt_burst
and tx_pkt_burst in eth_dev are not initialized while probing device.
This patch is to the initialization.
Signed-off-by: Yasufumi Ogawa <yasufum.o@gmail.com>
---
drivers/net/null/rte_eth_null.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c
index 0c60d241a..5a2010e3e 100644
--- a/drivers/net/null/rte_eth_null.c
+++ b/drivers/net/null/rte_eth_null.c
@@ -586,6 +586,13 @@ rte_pmd_null_probe(struct rte_vdev_device *dev)
/* TODO: request info from primary to set up Rx and Tx */
eth_dev->dev_ops = &ops;
eth_dev->device = &dev->device;
+ if (packet_copy) {
+ eth_dev->rx_pkt_burst = eth_null_copy_rx;
+ eth_dev->tx_pkt_burst = eth_null_copy_tx;
+ } else {
+ eth_dev->rx_pkt_burst = eth_null_rx;
+ eth_dev->tx_pkt_burst = eth_null_tx;
+ }
rte_eth_dev_probing_finish(eth_dev);
return 0;
}
--
2.17.1
next reply other threads:[~2019-09-29 2:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-29 2:41 Yasufumi Ogawa [this message]
2019-10-01 16:00 ` Ferruh Yigit
2019-10-01 16:03 ` Ferruh Yigit
2019-10-03 8:15 ` Yasufumi Ogawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190929024141.30443-1-yasufum.o@gmail.com \
--to=yasufum.o@gmail.com \
--cc=dev@dpdk.org \
--cc=mtetsuyah@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).