From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B9741A2EDB for ; Mon, 30 Sep 2019 17:50:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 35A921BECE; Mon, 30 Sep 2019 17:50:36 +0200 (CEST) Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id D1B7C1BECE for ; Mon, 30 Sep 2019 17:50:34 +0200 (CEST) Received: by mail-pg1-f194.google.com with SMTP id a24so7641393pgj.2 for ; Mon, 30 Sep 2019 08:50:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=s7AwAXjWDI/yEpD44QCUSpKl+jinPyjFuJocEZO5G5E=; b=TpYZe5ohyLMEnjt+5D9/W195GhjvAXGxi5QpGVQ1TXGzzMOb/aZNxrp/53G+WdRJlb yG2t7cBG9Pj4kXzrWWtQof2CZT2ngpMjLpIfa6f5DfWM3n7mjpwmqShIbQstJyXa/kuQ Qs4MYDGChI7HaQAWKy+pqLSRwDdGVoE6nVyikGdGKNiC4cV88tppnOHpsqh1AD3y9/fe AsIJ8nI+hBB0olierUkKwamAxCUVXBPMvwJ3qSLhkfP7jvJZnBD0/jZsTLJkrU4hFjjs Y99cAYld88auBzQtojGn1Y/SzfFxRAfEVRxzJkuFk9TZti9kCJJtCHmk1eGy2ZDBk5C5 j/Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=s7AwAXjWDI/yEpD44QCUSpKl+jinPyjFuJocEZO5G5E=; b=Fy3wb15mYl2A+wdl9Gj65+u264s7eYTvTtdYewlv4AtKAd75bfnhHi6pDexLH8Nx6b JTCVW7Au9CRHQyjBqQJB7ftf9vsxqduEl4IR3BqFCwFk142BY3l7zgoxGUMpNmiEGOoc b/ala0Bk21AQ9CCCCXR1Iq5KKwe+NKeZqcB57upjKDnIo05j/cVzMt36Jv78MiHnOaHE r8CONjhtyB39+HpexjQJVmXUy/gyHz/Kn2LqYfZST64TxM+m7kgCxD1giqhP7EAcaoiK 9xVDzZJ6x3iZjC1d/YGZTaKGOAbcmB0qrKuCWfZi7NXvd/pDLbgcIlW9ZC/RtCTyLlgn NPbA== X-Gm-Message-State: APjAAAXB+jvMG4Zvozcf3ShZSv52YC9BNo9bwB/3qKq4QSAOugmnGGHt 7UO1NyxvMDuceLspH5yD1Cp+CQ== X-Google-Smtp-Source: APXvYqwTfJt9zC0TbMTXD+KDWljJN6n595eg1j8tjHY9mqJtTHasPBolpcMcDVbpB8b2NxkKmgB6rA== X-Received: by 2002:a17:90a:cb18:: with SMTP id z24mr26934863pjt.108.1569858633957; Mon, 30 Sep 2019 08:50:33 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id p68sm23899430pfp.9.2019.09.30.08.50.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Sep 2019 08:50:33 -0700 (PDT) Date: Mon, 30 Sep 2019 08:50:32 -0700 From: Stephen Hemminger To: Ye Xiaolong Cc: Ferruh Yigit , wenzhuo.lu@intel.com, konstantin.ananyev@intel.com, beilei.xing@intel.com, qi.z.zhang@intel.com, xiao.w.wang@intel.com, jingjing.wu@intel.com, dev@dpdk.org Message-ID: <20190930085032.426fd5d3@hermes.lan> In-Reply-To: <20190930152838.GB18038@intel.com> References: <20190716154013.6974-1-stephen@networkplumber.org> <20190716154013.6974-2-stephen@networkplumber.org> <63111997-7c5c-a482-e42d-2e60259a40f2@intel.com> <20190930152838.GB18038@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/6] net/e1000: use dynamic log type for tx/rx debug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 30 Sep 2019 23:28:38 +0800 Ye Xiaolong wrote: > On 08/27, Ferruh Yigit wrote: > >On 7/16/2019 4:40 PM, Stephen Hemminger wrote: > >> The generic RTE_LOGTYPE_PMD is a historical relic and should > >> not be used. Every driver should register the logtypes > >> for itself. > >> > >> Signed-off-by: Stephen Hemminger > > > ><...> > > > >> +#ifdef RTE_LIBRTE_E1000_DEBUG_RX > >> + e1000_logtype_rx = rte_log_register("pmd.net.e1000.rx"); > >> + if (e1000_logtype_rx >= 0) > >> + rte_log_set_level(e1000_logtype_rx, RTE_LOG_NOTICE); > > > >What do you think setting default level for data path log level to > >'RTE_LOG_DEBUG' since they are already controlled by a config option, and to > >keep the behavior consistent with previous usage, because almost all macros are > >called with DEBUG level. Same for all drivers in this patchset. > > +1 > > Thanks, > Xiaolong Or drop DEBUG_RX and DEBUG_TX completely since they are not useful anymore. The code works, and distributions can not enable this.