From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 08A6BA2EDB for ; Mon, 30 Sep 2019 12:56:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D09729E4; Mon, 30 Sep 2019 12:56:26 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 1C1E92AB; Mon, 30 Sep 2019 12:56:24 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Sep 2019 03:56:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,565,1559545200"; d="scan'208";a="204804553" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by fmsmga001.fm.intel.com with ESMTP; 30 Sep 2019 03:56:22 -0700 Date: Mon, 30 Sep 2019 18:53:54 +0800 From: Ye Xiaolong To: Thierry Herbelot Cc: dev@dpdk.org, Laurent Hardy , Thomas Monjalon , stable@dpdk.org, beilei.xing@intel.com, qi.z.zhang@intel.com Message-ID: <20190930105354.GI112560@intel.com> References: <2121840c6dc59bcd1caffa8f4c8428fed5d667a7.1568216789.git.thierry.herbelot@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2121840c6dc59bcd1caffa8f4c8428fed5d667a7.1568216789.git.thierry.herbelot@6wind.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/i40e: set speed to undefined for default case in link update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 09/11, Thierry Herbelot wrote: >From: Laurent Hardy > >During PF/VF link update, a default speed value of 100M will be set >if get_link_info has failed or speed is unknown. > >Consequently if PF is put in no-carrier state, VFs will switch to >"in carrier" state due to a link up + a link speed set to 100M >(default value if no speed detected). > >To be consistent with linux drivers on which PF and VFs are in >same carrier state, sets default speed to undefined (instead of 100M) >and updates a link status of VF only if link is up and speed is >different from undefined. > >Fixes: 4861cde46116 ('i40e: new poll mode driver') >Cc: stable@dpdk.org >Cc: beilei.xing@intel.com >Cc: qi.z.zhang@intel.com > >Signed-off-by: Laurent Hardy >--- > drivers/net/i40e/i40e_ethdev.c | 4 ++-- > drivers/net/i40e/i40e_ethdev_vf.c | 8 +++++--- > 2 files changed, 7 insertions(+), 5 deletions(-) > Reviewed-by: Xiaolong Ye Applied to dpdk-next-net-intel.