From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B3ABBA2EDB for ; Mon, 30 Sep 2019 17:27:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1DB021BEB1; Mon, 30 Sep 2019 17:27:35 +0200 (CEST) Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by dpdk.org (Postfix) with ESMTP id A6CC51BE9D for ; Mon, 30 Sep 2019 17:27:30 +0200 (CEST) Received: by mail-pl1-f196.google.com with SMTP id s17so4045599plp.6 for ; Mon, 30 Sep 2019 08:27:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Q4INw0jXclEiki3qquDLRi7spTdZl6ftU0aD9i1ySi8=; b=fffF5NlXGSn262QLzQyP/YZPiWgO02Y2DOmV8cXBDlqRyeGNwDRhobAjBY6JwR99SU Vo7XP0P89egS6G4JoYUfw6iW2kDJHELCp/WM1l603wZlCFlp9G3c5R8VWgf7kCDe33JV ngpjRoG5p/bbutwobYK7Wqa7ePlUbq97fpercDg/ZDYqjGY3x59LsJ3UVipvjw6znmgV sx33CSGNsNHwcN4m8EpO9wIJrf1NkcHQLf1L2hlUPfuXn4SQqlSjY9WBAyshiHl9KXnt KnYsgFC/cIwVtRmVGNk7QXfQR2La8zLqn1lOoBZsa9lCVNhrqtsgBNLBKjTLnoAQHCUt fZGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Q4INw0jXclEiki3qquDLRi7spTdZl6ftU0aD9i1ySi8=; b=q/vtgbJ0dJN3KTunOcdZMaj0X5nh/fEn509U6x5RtJvHPzJYt4OTlFg825sxdC8xFP dttmlh81inh3oilTavDcVydh7PlSqII479gbvOhBAePGCh0MKqm5e6kyMKMB1e9WqVUi Wc2NfA5WtTJbC2X3CjsrGaDYSWKgQ52u8ggC8k0zC1LUrvgvwfhX7nzH2UO6LzylMCcr bFVsjgHfvh+K6pZ6uOrdzxDIcXe8PnXUuVkNHtusfQV6kE31VCfoaIGbrhjVRaEAQ7J8 5cU/GYvyUaRTz7iCiJOgnhDDZJ7WG9TkREmd/sFtywFiCCP4AkY4FwcsVOFYymmw9NTq AJtg== X-Gm-Message-State: APjAAAXRpOONN53Q+uPrOzBPT+40yRb3EbLBm7FOFz63t3MhNG3lcygi tRdo/kZOmPId+36hftTYc0fOktPItM4= X-Google-Smtp-Source: APXvYqxH3BQBjtkgZnum0EWWcAtRnokACkICjRMuCyugYgcaqpoXhvW/wdcE0gvyRTn/pcuG4S/LPg== X-Received: by 2002:a17:902:6545:: with SMTP id d5mr21213858pln.333.1569857249649; Mon, 30 Sep 2019 08:27:29 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id w14sm30521021pge.56.2019.09.30.08.27.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Sep 2019 08:27:28 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Mon, 30 Sep 2019 08:27:16 -0700 Message-Id: <20190930152721.8029-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190930152721.8029-1-stephen@networkplumber.org> References: <20190928003758.18489-1-stephen@networkplumber.org> <20190930152721.8029-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2 1/6] mbuf: don't generate invalid mbuf in clone test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The test for cloning changed mbuf would generate an mbuf whose length and segments were invalid. This would cause a crash if test was run with mbuf debugging enabled. Fixes: f1022aba76a5 ("app/test: rename mbuf variable") Signed-off-by: Stephen Hemminger --- app/test/test_mbuf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c index 2a97afe2044a..aafad0cf6206 100644 --- a/app/test/test_mbuf.c +++ b/app/test/test_mbuf.c @@ -332,8 +332,11 @@ testclone_testupdate_testdetach(struct rte_mempool *pktmbuf_pool) m->next = rte_pktmbuf_alloc(pktmbuf_pool); if (m->next == NULL) GOTO_FAIL("Next Pkt Null\n"); + m->nb_segs = 2; rte_pktmbuf_append(m->next, sizeof(uint32_t)); + m->pkt_len = 2 * sizeof(uint32_t); + data = rte_pktmbuf_mtod(m->next, unaligned_uint32_t *); *data = MAGIC_DATA; -- 2.20.1