From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id ECDEAA2EDB for ; Mon, 30 Sep 2019 17:31:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A32121BEC1; Mon, 30 Sep 2019 17:31:11 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 93E2C1BEB4 for ; Mon, 30 Sep 2019 17:31:09 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Sep 2019 08:31:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,567,1559545200"; d="scan'208";a="215741822" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by fmsmga004.fm.intel.com with ESMTP; 30 Sep 2019 08:31:07 -0700 Date: Mon, 30 Sep 2019 23:28:38 +0800 From: Ye Xiaolong To: Ferruh Yigit Cc: Stephen Hemminger , wenzhuo.lu@intel.com, konstantin.ananyev@intel.com, beilei.xing@intel.com, qi.z.zhang@intel.com, xiao.w.wang@intel.com, jingjing.wu@intel.com, dev@dpdk.org Message-ID: <20190930152838.GB18038@intel.com> References: <20190716154013.6974-1-stephen@networkplumber.org> <20190716154013.6974-2-stephen@networkplumber.org> <63111997-7c5c-a482-e42d-2e60259a40f2@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <63111997-7c5c-a482-e42d-2e60259a40f2@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH 1/6] net/e1000: use dynamic log type for tx/rx debug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 08/27, Ferruh Yigit wrote: >On 7/16/2019 4:40 PM, Stephen Hemminger wrote: >> The generic RTE_LOGTYPE_PMD is a historical relic and should >> not be used. Every driver should register the logtypes >> for itself. >> >> Signed-off-by: Stephen Hemminger > ><...> > >> +#ifdef RTE_LIBRTE_E1000_DEBUG_RX >> + e1000_logtype_rx = rte_log_register("pmd.net.e1000.rx"); >> + if (e1000_logtype_rx >= 0) >> + rte_log_set_level(e1000_logtype_rx, RTE_LOG_NOTICE); > >What do you think setting default level for data path log level to >'RTE_LOG_DEBUG' since they are already controlled by a config option, and to >keep the behavior consistent with previous usage, because almost all macros are >called with DEBUG level. Same for all drivers in this patchset. +1 Thanks, Xiaolong