From: David Christensen <drc@linux.vnet.ibm.com>
To: dev@dpdk.org
Cc: stable@dpdk.org, thibaut.collet@6wind.com,
maxime.coquelin@redhat.com, tiwei.bie@intel.com,
zhihong.wang@intel.com, jerinj@marvell.com, gavin.hu@arm.com,
David Christensen <drc@linux.vnet.ibm.com>
Subject: [dpdk-dev] [PATCH] net/virtio: get all pending Rx packets in altivec vectorized paths
Date: Mon, 30 Sep 2019 11:42:16 -0700 [thread overview]
Message-ID: <20190930184216.21587-1-drc@linux.vnet.ibm.com> (raw)
In-Reply-To: <4532a3e5b53802da7e1b35c6c9383b406a18c30d.1568216827.git.thierry.herbelot@6wind.com>
The loop to read packets does not take all packets as the number of
available packets (nb_used) is decremented in the loop.
Take all available packets provides a performance improvement of 3%.
Fixes: fc3d66212fed ("virtio: add vector Rx")
Cc: stable@dpdk.org
Cc: thibaut.collet@6wind.com
Cc: maxime.coquelin@redhat.com
Cc: tiwei.bie@intel.com
Cc: zhihong.wang@intel.com
Cc: jerinj@marvell.com
Cc: gavin.hu@arm.com
Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
---
drivers/net/virtio/virtio_rxtx_simple_altivec.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/virtio/virtio_rxtx_simple_altivec.c b/drivers/net/virtio/virtio_rxtx_simple_altivec.c
index f856396ab..47225f412 100644
--- a/drivers/net/virtio/virtio_rxtx_simple_altivec.c
+++ b/drivers/net/virtio/virtio_rxtx_simple_altivec.c
@@ -44,7 +44,7 @@ virtio_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,
struct virtnet_rx *rxvq = rx_queue;
struct virtqueue *vq = rxvq->vq;
struct virtio_hw *hw = vq->hw;
- uint16_t nb_used;
+ uint16_t nb_used, nb_total;
uint16_t desc_idx;
struct vring_used_elem *rused;
struct rte_mbuf **sw_ring;
@@ -109,9 +109,10 @@ virtio_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,
virtqueue_notify(vq);
}
+ nb_total = nb_used;
ref_rx_pkts = rx_pkts;
for (nb_pkts_received = 0;
- nb_pkts_received < nb_used;) {
+ nb_pkts_received < nb_total;) {
vector unsigned char desc[RTE_VIRTIO_DESC_PER_LOOP / 2];
vector unsigned char mbp[RTE_VIRTIO_DESC_PER_LOOP / 2];
vector unsigned char pkt_mb[RTE_VIRTIO_DESC_PER_LOOP];
--
2.18.1
next prev parent reply other threads:[~2019-09-30 18:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 16:04 [dpdk-dev] [PATCH 0/2] Fixes in virtio vectorized functions Thierry Herbelot
2019-09-11 16:04 ` [dpdk-dev] [PATCH 1/2] virtio: fix rx stats with " Thierry Herbelot
2019-09-27 9:08 ` Maxime Coquelin
2019-09-30 18:04 ` [dpdk-dev] [PATCH] net/virtio: fix Rx stats with altivec " David Christensen
2019-09-11 16:04 ` [dpdk-dev] [PATCH 2/2] virtio: get all pending rx packets with " Thierry Herbelot
2019-09-27 9:09 ` Maxime Coquelin
2019-09-30 18:27 ` [dpdk-dev] [PATCH] net/virtio: fix Rx stats with altivec " David Christensen
2019-10-01 10:00 ` Maxime Coquelin
2019-10-16 11:11 ` Maxime Coquelin
2019-09-30 18:42 ` David Christensen [this message]
2019-10-01 10:06 ` [dpdk-dev] [PATCH] net/virtio: get all pending Rx packets in altivec vectorized paths Maxime Coquelin
2019-10-16 11:11 ` Maxime Coquelin
2019-09-27 9:11 ` [dpdk-dev] [PATCH 0/2] Fixes in virtio vectorized functions Maxime Coquelin
2019-09-27 9:50 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190930184216.21587-1-drc@linux.vnet.ibm.com \
--to=drc@linux.vnet.ibm.com \
--cc=dev@dpdk.org \
--cc=gavin.hu@arm.com \
--cc=jerinj@marvell.com \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=thibaut.collet@6wind.com \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).