From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F3313A2EDB for ; Tue, 1 Oct 2019 14:17:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7192644C7; Tue, 1 Oct 2019 14:17:33 +0200 (CEST) Received: from dish-sg.nttdocomo.co.jp (dish-sg.nttdocomo.co.jp [202.19.227.74]) by dpdk.org (Postfix) with ESMTP id 267A844C3 for ; Tue, 1 Oct 2019 14:17:31 +0200 (CEST) X-dD-Source: Outbound Received: from zssg-mailmd104.ddreams.local (zssg-mailmd900.ddreams.local [10.160.172.63]) by zssg-mailou104.ddreams.local (Postfix) with ESMTP id 720A31200D1; Tue, 1 Oct 2019 21:17:29 +0900 (JST) Received: from t131sg-mailcc12.ddreams.local (t131sg-mailcc12.ddreams.local [100.66.31.87]) by zssg-mailmd104.ddreams.local (dDREAMS) with ESMTP id <0PYP008BV3H5R970@dDREAMS>; Tue, 01 Oct 2019 21:17:29 +0900 (JST) Received: from t131sg-mailcc12 (localhost [127.0.0.1]) by t131sg-mailcc12.ddreams.local (unknown) with SMTP id x91CHTnW040400; Tue, 1 Oct 2019 21:17:29 +0900 Received: from zssg-mailmf106.ddreams.local (unknown [127.0.0.1]) by zssg-mailmf106.ddreams.local (Postfix) with ESMTP id 293A27E6032; Tue, 1 Oct 2019 21:17:17 +0900 (JST) Received: from zssg-mailmf106.ddreams.local (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 280C98E6055; Tue, 1 Oct 2019 21:17:17 +0900 (JST) Received: from localhost (unknown [127.0.0.1]) by IMSVA (Postfix) with SMTP id 26D158E6042; Tue, 1 Oct 2019 21:17:17 +0900 (JST) X-IMSS-HAND-OFF-DIRECTIVE: localhost:10026 Received: from zssg-mailmf106.ddreams.local (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 442F58E6042; Tue, 1 Oct 2019 21:17:16 +0900 (JST) Received: from zssg-mailua105.ddreams.local (unknown [10.160.172.62]) by zssg-mailmf106.ddreams.local (Postfix) with ESMTP; Tue, 1 Oct 2019 21:17:16 +0900 (JST) Received: from [10.87.198.18] (unknown [10.160.183.129]) by zssg-mailua105.ddreams.local (dDREAMS) with ESMTPA id <0PYP00I9W3GRON70@dDREAMS>; Tue, 01 Oct 2019 21:17:16 +0900 (JST) Date: Tue, 01 Oct 2019 21:17:16 +0900 From: Hideyuki Yamashita In-reply-to: References: <1558020019-156458-1-git-send-email-motih@mellanox.com> Message-id: <20191001211715.69C2.17218CA3@ntt-tx.co.jp_1> MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Mailer: Becky! ver. 2.74.02 [ja] X-TM-AS-GCONF: 00 To: Moti Haimovsky Cc: viacheslavo@mellanox.com, dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 0/7] net/mlx5: support for flow action on VLAN header X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Moti, I have some questions on the patch. Just want to know how to use it. Q1. Is it correct understanding that the patch will be reflected in 19.11 if it is approved? Q2.Which action should I specify when I want to insert VLAN tag to non-VLAN frame? OF_PUSH_VLAN and OF_SET_VLAN_VID and OF_SET_VLAN_PCP ? Q3. Is it possible to detag VLAN when it receives VLAN tagged frame from outside of the host? Q4. Is it possible to entag VLAN to non-VLAN frame when it sends packet to outside of host? Q5.Are there any restriction to conbime other ACTIONS like QUEUE? Q6. Is it possible to apply rte_flow actions for specified tx queue of physical NIC? (e.g. VM connect with PHY:0 using tx queue index:1, I want to entag VLAN 101 to the traffic from VM to PHY:0 is it possible?) Thanks in advance! BR, Hideyuki Yamashita NTT TechnoCross > VLAN actions support is implemented in librte_ethdev, and in > test-pmd application, based on [1] Generic flow API. > These actions conform to the VLAN actions defined in > [2] the OpenFlow Switch Specification. > > rte_flow defines the following VLAN actions: > 1. OF_POP_VLAN > Pop the outer-most VLAN header from the packet. > 2. OF_PUSH_VLAN > Push a new VLAN header onto the packet. > 3. OF_SET_VLAN_VID > Sets the ID of the outermost VLAN tag. > 4. OF_SET_VLAN_PCP > Sets the 3-bit priority field of the outermost VLAN tag. > > This series of patches adds support for those VLAN actions > to the mlx5 PMD using the Direct Verbs interface. > > Moti Haimovsky (7): > net/mlx5: support for an action search in a list > net/mlx5: add VLAN push/pop DR commands to glue > net/mlx5: support pop flow action on VLAN header > net/mlx5: support push flow action on VLAN header > net/mlx5: support modify VLAN priority on VLAN hdr > net/mlx5: supp modify VLAN ID on new VLAN header > net/mlx5: supp modify VLAN ID on existing VLAN hdr > > drivers/net/mlx5/Makefile | 5 + > drivers/net/mlx5/meson.build | 2 + > drivers/net/mlx5/mlx5.c | 9 + > drivers/net/mlx5/mlx5.h | 3 + > drivers/net/mlx5/mlx5_flow.c | 23 ++ > drivers/net/mlx5/mlx5_flow.h | 27 ++- > drivers/net/mlx5/mlx5_flow_dv.c | 521 ++++++++++++++++++++++++++++++++++++++++ > drivers/net/mlx5/mlx5_glue.c | 29 +++ > drivers/net/mlx5/mlx5_glue.h | 6 + > drivers/net/mlx5/mlx5_prm.h | 1 + > 10 files changed, 623 insertions(+), 3 deletions(-) > > -- > 1.8.3.1