From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 99FC9A2F63 for ; Fri, 4 Oct 2019 07:04:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1B9691C1EC; Fri, 4 Oct 2019 07:03:15 +0200 (CEST) Received: from rnd-relay.smtp.broadcom.com (unknown [192.19.229.170]) by dpdk.org (Postfix) with ESMTP id AFEED1C1B5 for ; Fri, 4 Oct 2019 07:02:55 +0200 (CEST) Received: from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net [10.75.242.48]) by rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 8E4FA30C2D1; Thu, 3 Oct 2019 22:01:35 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 8E4FA30C2D1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1570165295; bh=3simAWPQ94bTremN9u92fCf+OMDlKMrBNBTkevqxLcs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=O9fIRQ356zfHbbhWOlubgcUXwW3frcYgCX+P5BqjUmgj1I2XTl/piUXFjr7+6w/13 +n8Cx80QniOovHwVzMfQ4oYHISyV8hloLD1bDqmFQxBOEHL6+cUCjztMuOKNsmUGe0 rXmHj6j7fDqBAx87JYOc7ntvTtxnyQ/AyrLXr5o4= Received: from localhost.localdomain (unknown [10.230.30.225]) by mail-irv-17.broadcom.com (Postfix) with ESMTP id 93090140069; Thu, 3 Oct 2019 22:02:51 -0700 (PDT) From: Ajit Khaparde To: dev@dpdk.org Cc: ferruh.yigit@intel.com, Kalesh AP Date: Thu, 3 Oct 2019 22:02:46 -0700 Message-Id: <20191004050246.90165-11-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.20.1 (Apple Git-117) In-Reply-To: <20191004050246.90165-1-ajit.khaparde@broadcom.com> References: <20191004050246.90165-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 10/10] net/bnxt: remove a useless check in validate flow routine X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Kalesh AP Since vnic->rx_queue_cnt is already checked against non-zero, removed the useless check from the inside condition check. Fixes: 4be31562a4ba ("net/bnxt: allow flow creation when RSS is enabled") Signed-off-by: Kalesh AP Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_flow.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c index d753a334b9..5aeb001408 100644 --- a/drivers/net/bnxt/bnxt_flow.c +++ b/drivers/net/bnxt/bnxt_flow.c @@ -1067,8 +1067,7 @@ bnxt_validate_and_parse_flow(struct rte_eth_dev *dev, goto ret; } if (vnic->rx_queue_cnt) { - if (vnic->rx_queue_cnt > 1 || - vnic->start_grp_id != act_q->index) { + if (vnic->start_grp_id != act_q->index) { PMD_DRV_LOG(ERR, "VNIC already in use\n"); rte_flow_error_set(error, -- 2.20.1 (Apple Git-117)