From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org, Nicolas Chautru <nicolas.chautru@intel.com>
Cc: Akhil Goyal <akhil.goyal@nxp.com>,
Andrzej Ostruszka <amo@semihalf.com>,
Bruce Richardson <bruce.richardson@intel.com>
Subject: [dpdk-dev] [PATCH 0/5] some bbdev cleanups
Date: Fri, 4 Oct 2019 18:19:08 +0100 [thread overview]
Message-ID: <20191004171913.59574-1-bruce.richardson@intel.com> (raw)
As pointed out in the discussion of the patchset for building shared and
static libraries separately [1], the test_bbdev_perf.c file explicitly
disables some code for shared library builds. This is due to functions
not being properly exported from one of the baseband drivers.
While fixing this and looking to remove the #ifdef for shared libraries,
it was discovered that the per-driver macro used in that file was
incorrect for use in the meson build due to inconsistencies of naming
between the two builds.
Therefore, this set adjusts the macros and names of the drivers so that
they are consistent across drivers, and between both meson and make.
Thereafter the missing function for the fpga_lte_fec driver is exported
and the #ifdef removed from the code.
After these patches are replied, the only instance of the
RTE_BUILD_SHARED_LIB macro used in .c/.h file is in rte_compat.h for
function versioning support.
[1] http://patches.dpdk.org/project/dpdk/list/?series=6596
Bruce Richardson (5):
drivers/baseband: align meson defines with make
baseband/fpga_lte_fec: align naming to other bbdevs
drivers/baseband: remove override of driver names
baseband/fpga_lte_fec: add public API to map file
app/test-bbdev: enable fpga_lte_fec support in shared builds
app/test-bbdev/Makefile | 3 +++
app/test-bbdev/meson.build | 6 +++---
app/test-bbdev/test_bbdev_perf.c | 8 +++-----
config/common_base | 2 +-
doc/guides/bbdevs/fpga_lte_fec.rst | 2 +-
drivers/baseband/Makefile | 2 +-
drivers/baseband/fpga_lte_fec/Makefile | 6 +++---
drivers/baseband/fpga_lte_fec/fpga_lte_fec.h | 1 +
drivers/baseband/fpga_lte_fec/meson.build | 1 -
.../fpga_lte_fec/rte_pmd_bbdev_fpga_lte_fec_version.map | 4 ++++
drivers/baseband/meson.build | 4 ++--
drivers/baseband/null/meson.build | 1 -
drivers/baseband/turbo_sw/meson.build | 1 -
mk/rte.app.mk | 2 +-
14 files changed, 23 insertions(+), 20 deletions(-)
--
2.21.0
next reply other threads:[~2019-10-04 17:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 17:19 Bruce Richardson [this message]
2019-10-04 17:19 ` [dpdk-dev] [PATCH 1/5] drivers/baseband: align meson defines with make Bruce Richardson
2019-10-04 17:19 ` [dpdk-dev] [PATCH 2/5] baseband/fpga_lte_fec: align naming to other bbdevs Bruce Richardson
2019-10-04 17:19 ` [dpdk-dev] [PATCH 3/5] drivers/baseband: remove override of driver names Bruce Richardson
2019-10-04 17:19 ` [dpdk-dev] [PATCH 4/5] baseband/fpga_lte_fec: add public API to map file Bruce Richardson
2019-10-04 17:19 ` [dpdk-dev] [PATCH 5/5] app/test-bbdev: enable fpga_lte_fec support in shared builds Bruce Richardson
2019-10-07 18:29 ` Chautru, Nicolas
2019-10-09 9:28 ` [dpdk-dev] [PATCH 0/5] some bbdev cleanups Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191004171913.59574-1-bruce.richardson@intel.com \
--to=bruce.richardson@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=amo@semihalf.com \
--cc=dev@dpdk.org \
--cc=nicolas.chautru@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).