From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5BC98A2F67 for ; Fri, 4 Oct 2019 19:19:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6AB3A1C242; Fri, 4 Oct 2019 19:19:25 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 1291C1C225 for ; Fri, 4 Oct 2019 19:19:23 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Oct 2019 10:19:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,257,1566889200"; d="scan'208";a="217228452" Received: from silpixa00399126.ir.intel.com (HELO silpixa00399126.ger.corp.intel.com) ([10.237.223.2]) by fmsmga004.fm.intel.com with ESMTP; 04 Oct 2019 10:19:21 -0700 From: Bruce Richardson To: dev@dpdk.org, Nicolas Chautru Cc: Akhil Goyal , Andrzej Ostruszka , Bruce Richardson Date: Fri, 4 Oct 2019 18:19:08 +0100 Message-Id: <20191004171913.59574-1-bruce.richardson@intel.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 0/5] some bbdev cleanups X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" As pointed out in the discussion of the patchset for building shared and static libraries separately [1], the test_bbdev_perf.c file explicitly disables some code for shared library builds. This is due to functions not being properly exported from one of the baseband drivers. While fixing this and looking to remove the #ifdef for shared libraries, it was discovered that the per-driver macro used in that file was incorrect for use in the meson build due to inconsistencies of naming between the two builds. Therefore, this set adjusts the macros and names of the drivers so that they are consistent across drivers, and between both meson and make. Thereafter the missing function for the fpga_lte_fec driver is exported and the #ifdef removed from the code. After these patches are replied, the only instance of the RTE_BUILD_SHARED_LIB macro used in .c/.h file is in rte_compat.h for function versioning support. [1] http://patches.dpdk.org/project/dpdk/list/?series=6596 Bruce Richardson (5): drivers/baseband: align meson defines with make baseband/fpga_lte_fec: align naming to other bbdevs drivers/baseband: remove override of driver names baseband/fpga_lte_fec: add public API to map file app/test-bbdev: enable fpga_lte_fec support in shared builds app/test-bbdev/Makefile | 3 +++ app/test-bbdev/meson.build | 6 +++--- app/test-bbdev/test_bbdev_perf.c | 8 +++----- config/common_base | 2 +- doc/guides/bbdevs/fpga_lte_fec.rst | 2 +- drivers/baseband/Makefile | 2 +- drivers/baseband/fpga_lte_fec/Makefile | 6 +++--- drivers/baseband/fpga_lte_fec/fpga_lte_fec.h | 1 + drivers/baseband/fpga_lte_fec/meson.build | 1 - .../fpga_lte_fec/rte_pmd_bbdev_fpga_lte_fec_version.map | 4 ++++ drivers/baseband/meson.build | 4 ++-- drivers/baseband/null/meson.build | 1 - drivers/baseband/turbo_sw/meson.build | 1 - mk/rte.app.mk | 2 +- 14 files changed, 23 insertions(+), 20 deletions(-) -- 2.21.0