From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 837BFA2EEB for ; Mon, 7 Oct 2019 19:33:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BB6081C123; Mon, 7 Oct 2019 19:33:52 +0200 (CEST) Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id 470AF1C113 for ; Mon, 7 Oct 2019 19:33:51 +0200 (CEST) Received: by mail-pg1-f194.google.com with SMTP id i32so1319857pgl.10 for ; Mon, 07 Oct 2019 10:33:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1Q5Mz3EKbfx6Bh3IJt/DPEh8oT2ZEdHXuRvrc9DCGjU=; b=RtaJ2NHlRY4bBkiv5rdO0eysOWsl4D6EpJd0go9muW1eNPtox5jFZ+hHpeMB8JLrN2 Qys8pvdz63e2JrPDLyDczmWcRD573PNGTKjmJaOgyYLsb66b72oRN2HPoQCu4gRaB8UU ug5NCmeYVuP7GeSL8W6UPpv3cXtmsUAzTdoqwkMdQM7Oe9fTidC64CP4aGvS6o5+hwJj CmvQpR1KWY9Qvc2pqnwzAVzW1t1Fj0u/GskXcpVTZGflX/HPRcCywigUEKw402vtrPn1 zzGrmH03vDJr/T0VMcXn8ClCZyaxkrI9QZKe3f5XrCw7a+ASMURBRSQERBa+KxPWsWIA CozQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1Q5Mz3EKbfx6Bh3IJt/DPEh8oT2ZEdHXuRvrc9DCGjU=; b=DZnSYSGWo3no+8dCpaWOaiRODia2Z9b7QyORxHRy5g1vivZ4IbPaJ/FSB28wc/NZd1 DdcE5kjv0wOFtMHozO7Kzxzogm/sQ/Lvyf8SKYJFjOdKGFSR0DQHCRUaJdKywyC15lG5 O5LiMiLnJ7ngv/y4FsGNtdygjrS+Hi++sirUDtwzEvODae2ov3rHOd03fga2KAKxE+nM aiqfoHMkVA395QrSOaJx0op9eEDTiACeZw/RfncR2BiJg5o4/lRgSwSjFuUbbeB04AMJ fzMvHfEym6fe7ZCq8qthuRlBMbYZN7PSUC1R4Lcoj9mvcJsPien2kAwhTR76qginbSoM ApQA== X-Gm-Message-State: APjAAAWp8nyL39AXy7IsAysM054qysCsoDpJU/xkMEijV6v1Oy16QNEk nOkNMvBx+sqF9dfNXKpWVzDD9w== X-Google-Smtp-Source: APXvYqw4gAijpj7o0EHT1lwM/uBJTXAmuOweyZoc45XyVG7e8AVVIBrUUVaatPsw7qXXRMJsvjVSKA== X-Received: by 2002:aa7:9196:: with SMTP id x22mr33078932pfa.150.1570469630027; Mon, 07 Oct 2019 10:33:50 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id 193sm17515518pfc.59.2019.10.07.10.33.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2019 10:33:49 -0700 (PDT) Date: Mon, 7 Oct 2019 10:33:43 -0700 From: Stephen Hemminger To: Jerin Jacob Cc: dpdk-dev Message-ID: <20191007103343.6d199594@hermes.lan> In-Reply-To: References: <20191007165232.14535-1-stephen@networkplumber.org> <20191007165232.14535-6-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC 5/8] pdump: add classic BPF filtering X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 7 Oct 2019 22:37:43 +0530 Jerin Jacob wrote: > On Mon, 7 Oct, 2019, 10:23 PM Stephen Hemminger, > wrote: > > > Simple classic BPF interpreter based off of libpcap. > > > > This is a copy of the BPF interpreter from libpcap which is > > modified to handle mbuf meta data. The existing pcap_offline_filter > > does not expose a way to match VLAN tags. Copying the BPF interpreter > > also means that rte_pdump still does not have a hard dependency > > on libpcap. > > > > Why not use DPDK's librte_bpf library? Rather implementing cBPF > interpreter. Currently it supports eBPF which is super set of cBPF.if is > this features very specific to cBPF, we clould simply implement cBPF using > eBPF or implement a new cBPF program type. That scheme could leverage > existing JIT infrastructure also. Using JIT will improve filtering > performance. > > > > > Because pcap library generates cBPF in its string to BPF compiler. Translating cBPF to eBPF is non trivial.