From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B79F0A2EEB for ; Mon, 7 Oct 2019 13:10:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8E4221C210; Mon, 7 Oct 2019 13:10:11 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 24CF51C1F8 for ; Mon, 7 Oct 2019 13:10:09 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Oct 2019 04:10:08 -0700 X-IronPort-AV: E=Sophos;i="5.67,268,1566889200"; d="scan'208";a="183399647" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.95]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Oct 2019 04:10:07 -0700 Date: Mon, 7 Oct 2019 12:10:03 +0100 From: Bruce Richardson To: Kevin Traynor Cc: Marcin Baran , dev@dpdk.org Message-ID: <20191007111003.GA1844@bricha3-MOBL.ger.corp.intel.com> References: <20190920073714.1314-1-marcinx.baran@intel.com> <20190930075034.2000-1-marcinx.baran@intel.com> <82804089-268a-9a2c-85cb-0dfaaab1963d@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <82804089-268a-9a2c-85cb-0dfaaab1963d@redhat.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH v6 0/6] examples/ioat: sample app on ioat driver usage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 04, 2019 at 06:16:55PM +0100, Kevin Traynor wrote: > On 30/09/2019 08:50, Marcin Baran wrote: > > A new sample app demonstrating use of driver for CBDMA. > > The app receives packets, performs software or hardware > > copy, changes packets' MAC addresses (if enabled) and > > forwards them. The patch includes sample application as > > well as it's guide. > > > > v6: > > - rearrange 'ioat_tx_port()' to remove unnecessary code > > - improve documentation > > - format patches for better readability > > > > v5: > > - change dependency name from 'pmd_ioat' to 'rawdev_ioat' > > fixing build errors (branch diverged from master) > > > > v4: > > - fix meson build support check > > > > v3: > > - add check for meson build whether IOAT is supported > > > > v2: > > - change printing total stats to be deltas > > - update documentation > > - fix 1 thread/sw copy/multiple Rx queues packet dropping > > - divide patch into several presenting functional change > > > > > > Marcin Baran (4): > > examples/ioat: add software copy support > > examples/ioat: add rawdev copy mode support > > examples/ioat: add stats printing for each port > > doc/guides/: provide IOAT sample app guide > > > > Pawel Modrak (2): > > examples/ioat: create sample app on ioat driver usage > > examples/ioat: add two threads configuration > > > > doc/guides/sample_app_ug/index.rst | 1 + > > doc/guides/sample_app_ug/intro.rst | 4 + > > doc/guides/sample_app_ug/ioat.rst | 581 ++++++++++++++++ > > examples/Makefile | 3 + > > examples/ioat/Makefile | 54 ++ > > examples/ioat/ioatfwd.c | 1003 ++++++++++++++++++++++++++++ > > examples/ioat/meson.build | 15 + > > examples/meson.build | 1 + > > 8 files changed, 1662 insertions(+) > > create mode 100644 doc/guides/sample_app_ug/ioat.rst > > create mode 100644 examples/ioat/Makefile > > create mode 100644 examples/ioat/ioatfwd.c > > create mode 100644 examples/ioat/meson.build > > > > Just a nit, but I think you need to add something to the MAINTAINERS > file for this example app, maybe it can be a follow up patch if it's the > only rework Good catch. For completeness I've sent up a V7 of this set, adding this example under the existing ioat section in MAINTAINERS. /Bruce