From: Stephen Hemminger <stephen@networkplumber.org>
To: Jim Harris <james.r.harris@intel.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com, anatoly.burakov@intel.com
Subject: Re: [dpdk-dev] [PATCH v2 RESEND] timer: remove check_tsc_flags()
Date: Mon, 7 Oct 2019 16:18:54 -0700 [thread overview]
Message-ID: <20191007161854.0d4bbad0@hermes.lan> (raw)
In-Reply-To: <157046280565.10885.5236700707414855268.stgit@jrharri1-skx>
On Mon, 07 Oct 2019 08:40:05 -0700
Jim Harris <james.r.harris@intel.com> wrote:
> This code was added 7+ years ago:
>
> commit fb022b85bae4 ("timer: check TSC reliability")
>
> presumably when variant TSCs were still somewhat
> common? But this code doesn't do anything except print
> a warning, and the warning doesn't give any kind of
> advice to the user, so let's just remove it.
>
> While the warning has no functional meaning, the
> /proc/cpuinfo parsing consumes a non-trivial amount
> of time which is especially noticeable in secondary
> processes. On my test system, it consumes
> 21ms out of the 66ms total execution time for
> rte_eal_init() in a secondary process.
>
> Signed-off-by: Jim Harris <james.r.harris@intel.com>
Yes this code is dead.
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2019-10-07 23:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 10:18 [dpdk-dev] [PATCH v2] " Jim Harris
2019-10-07 15:40 ` [dpdk-dev] [PATCH v2 RESEND] " Jim Harris
2019-10-07 23:18 ` Stephen Hemminger [this message]
2019-10-08 8:36 ` Bruce Richardson
2019-10-08 15:15 ` Stephen Hemminger
2019-10-18 4:10 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191007161854.0d4bbad0@hermes.lan \
--to=stephen@networkplumber.org \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=james.r.harris@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).