From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C30F1A2F6B for ; Tue, 8 Oct 2019 01:19:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CFBF71C066; Tue, 8 Oct 2019 01:19:03 +0200 (CEST) Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id 802AF1C05C for ; Tue, 8 Oct 2019 01:19:02 +0200 (CEST) Received: by mail-pg1-f194.google.com with SMTP id x10so9139179pgi.5 for ; Mon, 07 Oct 2019 16:19:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8vdYAEbf2+1uWdLgHvOt1h2Z7B/c7zZJlLrSmmyCoSs=; b=UkqCVzeinqALjnlKhQp5yjsgJI9ctejuJQs2zmaQjS1kZku8Fr5yfpZ2KKobTMyluc A/Msp3lfccx1fE9WwJO5THcK3f8HTOIymj9jBcA2ld5aRXQVl6FZFKu8CKIAdU/0Bgk2 LUz0hPhH4+QpmSktlPqRD2GQgepIwWEPWoVhA/5xJRbg8MwXhGbrHJ/yePKmPsZQxeWv H1eqqBYIf5SnUe0Kt/r9HAlvJG33bliQWcTSNVi33NZu5ZSmNVceJ1j+Kqk09wcP378n dosH1Iswz2mN9Vb1oL3xVMzxegDzlPHGbyz5Cb6f6PGhyWh4xGVbVWRK3wZfZDom8jrY FZ8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8vdYAEbf2+1uWdLgHvOt1h2Z7B/c7zZJlLrSmmyCoSs=; b=RZ8Klp5gpSw0Rh0F80MY7q8Bpl0rd1E/7pdF7Tlgk9n2qNeRgi5JUNtfq2mpNh0xp8 gYtpvhVtVZP1asmHGcvZHgPcJ4L36s948KREhMUqaBXSS9HbaSgyePoVsa2SsEcWxfFF SzgZMUc58Z4XofsWzRRpn/az5SoDXlpd6ahC/xY+ZRqBxWH3eTbwXqwB/kCEzefbe3pR QvAz0R7jnt4cCDNoQXS8z2ke5soHKntv9F5oK4FY6302EEcA1fV9XYs9p6ceBXDwjP/R 8zDsHUyXA/lPEpJtEltlYg0qO3l4s4TrNPEgkj5b5rMCtJ0OaGdLhBpD2r1ugfZ0F1Lb vOJQ== X-Gm-Message-State: APjAAAVK1vMDvRCgOCEm0u56Ebs5+IViQ6iqkkqavZY803uBGGfDGoXc ir42O1+2ifNbX046dhnfAgFZuA== X-Google-Smtp-Source: APXvYqx2kLA+A8zBgitVc/L7uAo4XNh9rVv11sqGnDTeKMiIkFeUtixlkWt45phpBDo7gxT55wDuyQ== X-Received: by 2002:aa7:9ab4:: with SMTP id x20mr36506780pfi.59.1570490341397; Mon, 07 Oct 2019 16:19:01 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id r2sm17869257pfq.60.2019.10.07.16.19.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2019 16:19:01 -0700 (PDT) Date: Mon, 7 Oct 2019 16:18:54 -0700 From: Stephen Hemminger To: Jim Harris Cc: dev@dpdk.org, bruce.richardson@intel.com, anatoly.burakov@intel.com Message-ID: <20191007161854.0d4bbad0@hermes.lan> In-Reply-To: <157046280565.10885.5236700707414855268.stgit@jrharri1-skx> References: <156638268505.9344.18339364696357608254.stgit@jrharri1-skx> <157046280565.10885.5236700707414855268.stgit@jrharri1-skx> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 RESEND] timer: remove check_tsc_flags() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 07 Oct 2019 08:40:05 -0700 Jim Harris wrote: > This code was added 7+ years ago: > > commit fb022b85bae4 ("timer: check TSC reliability") > > presumably when variant TSCs were still somewhat > common? But this code doesn't do anything except print > a warning, and the warning doesn't give any kind of > advice to the user, so let's just remove it. > > While the warning has no functional meaning, the > /proc/cpuinfo parsing consumes a non-trivial amount > of time which is especially noticeable in secondary > processes. On my test system, it consumes > 21ms out of the 66ms total execution time for > rte_eal_init() in a secondary process. > > Signed-off-by: Jim Harris Yes this code is dead. Acked-by: Stephen Hemminger