From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E1D9FA2F6B for ; Tue, 8 Oct 2019 10:36:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 49B301BF27; Tue, 8 Oct 2019 10:36:57 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 4A26A1BF0A for ; Tue, 8 Oct 2019 10:36:55 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Oct 2019 01:36:55 -0700 X-IronPort-AV: E=Sophos;i="5.67,270,1566889200"; d="scan'208";a="277038105" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.95]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Oct 2019 01:36:53 -0700 Date: Tue, 8 Oct 2019 09:36:49 +0100 From: Bruce Richardson To: Stephen Hemminger Cc: Jim Harris , dev@dpdk.org, anatoly.burakov@intel.com Message-ID: <20191008083649.GA1856@bricha3-MOBL.ger.corp.intel.com> References: <156638268505.9344.18339364696357608254.stgit@jrharri1-skx> <157046280565.10885.5236700707414855268.stgit@jrharri1-skx> <20191007161854.0d4bbad0@hermes.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191007161854.0d4bbad0@hermes.lan> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH v2 RESEND] timer: remove check_tsc_flags() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Oct 07, 2019 at 04:18:54PM -0700, Stephen Hemminger wrote: > On Mon, 07 Oct 2019 08:40:05 -0700 Jim Harris > wrote: > > > This code was added 7+ years ago: > > > > commit fb022b85bae4 ("timer: check TSC reliability") > > > > presumably when variant TSCs were still somewhat common? But this code > > doesn't do anything except print a warning, and the warning doesn't > > give any kind of advice to the user, so let's just remove it. > > > > While the warning has no functional meaning, the /proc/cpuinfo parsing > > consumes a non-trivial amount of time which is especially noticeable in > > secondary processes. On my test system, it consumes 21ms out of the > > 66ms total execution time for rte_eal_init() in a secondary process. > > > > Signed-off-by: Jim Harris > > Yes this code is dead. > > Acked-by: Stephen Hemminger > +1 for this. Even if it was needed, we should never parse /proc/cpuinfo, since we have a DPDK function to query cpuid directly anyway. Acked-by: Bruce Richardson