From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2B063A2F6B for ; Tue, 8 Oct 2019 10:38:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 810B31BFC4; Tue, 8 Oct 2019 10:38:48 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 5EB481BF27 for ; Tue, 8 Oct 2019 10:38:47 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Oct 2019 01:38:38 -0700 X-IronPort-AV: E=Sophos;i="5.67,270,1566889200"; d="scan'208";a="277038480" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.95]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Oct 2019 01:38:37 -0700 Date: Tue, 8 Oct 2019 09:38:33 +0100 From: Bruce Richardson To: Jim Harris Cc: dev@dpdk.org, anatoly.burakov@intel.com Message-ID: <20191008083833.GB1856@bricha3-MOBL.ger.corp.intel.com> References: <156646334762.14099.13593080473257757748.stgit@jrharri1-skx> <157046210105.10142.15291330038149009146.stgit@jrharri1-skx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <157046210105.10142.15291330038149009146.stgit@jrharri1-skx> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH v6 RESEND] eal: add tsc_hz to rte_mem_config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Oct 07, 2019 at 08:28:21AM -0700, Jim Harris wrote: > This ensures secondary processes never have to > calculate the TSC rate themselves, which can be > noticeable in VMs that don't have access to > arch-specific detection mechanism (such as > CPUID leaf 0x15 or MSR 0xCE on x86). > > Since rte_mem_config is now internal to the rte_eal > library, we can add tsc_hz without ABI breakage > concerns. > > Reduces rte_eal_init() execution time in a secondary > process from 165ms to 66ms on my test system. > > Signed-off-by: Jim Harris > --- This seems a good idea to me. Acked-by: Bruce Richardson