From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id BE434A2F6B
	for <public@inbox.dpdk.org>; Tue,  8 Oct 2019 11:36:36 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 02EE21C216;
	Tue,  8 Oct 2019 11:36:31 +0200 (CEST)
Received: from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com
 [62.23.145.76]) by dpdk.org (Postfix) with ESMTP id CA7571C20B
 for <dev@dpdk.org>; Tue,  8 Oct 2019 11:36:29 +0200 (CEST)
Received: from glumotte.dev.6wind.com (unknown [10.16.0.195])
 by proxy.6wind.com (Postfix) with ESMTP id B1F0A329979;
 Tue,  8 Oct 2019 11:36:29 +0200 (CEST)
Date: Tue, 8 Oct 2019 11:36:29 +0200
From: Olivier Matz <olivier.matz@6wind.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Cc: Vamsi Krishna Attunuru <vattunuru@marvell.com>, dev@dpdk.org,
 Thomas Monjalon <thomas@monjalon.net>,
 Anatoly Burakov <anatoly.burakov@intel.com>,
 Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
 Kokkilagadda <kirankumark@marvell.com>,
 Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <20191008093629.GV7277@glumotte.dev.6wind.com>
References: <CH2PR18MB338160CD8EF16EEB45EED387A6C80@CH2PR18MB3381.namprd18.prod.outlook.com>
 <20190719133845.32432-1-olivier.matz@6wind.com>
 <20190719133845.32432-2-olivier.matz@6wind.com>
 <efd70897-1511-cc6c-54cf-840af2deb07e@solarflare.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <efd70897-1511-cc6c-54cf-840af2deb07e@solarflare.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Subject: Re: [dpdk-dev] [RFC 1/4] mempool: clarify default populate function
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Jul 19, 2019 at 06:42:06PM +0300, Andrew Rybchenko wrote:
> On 7/19/19 4:38 PM, Olivier Matz wrote:
> > No functional change. Clarify the populate function to make
> > the next commit easier to understand.
> > 
> > Rename the variables:
> > - to avoid negation in the name
> > - to have more understandable names
> > 
> > Remove useless variable (no_pageshift is equivalent to pg_sz == 0).
> > 
> > Remove duplicate affectation of "external" variable.
> > 
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> 
> LGTM
> 
> Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>
> 

I submitted this one in a separate patch:
http://patchwork.dpdk.org/patch/60687/