From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: thomas@monjalon.net, Neil Horman <nhorman@tuxdriver.com>,
bluca@debian.org, ray.kinsella@intel.com,
Bruce Richardson <bruce.richardson@intel.com>
Subject: [dpdk-dev] [PATCH 2/3] lib: add experimental symbols check to meson build
Date: Tue, 8 Oct 2019 15:36:27 +0100 [thread overview]
Message-ID: <20191008143628.46054-3-bruce.richardson@intel.com> (raw)
In-Reply-To: <20191008143628.46054-1-bruce.richardson@intel.com>
Call check-experimental-syms.sh script as part of the meson build to ensure
that all functions are correctly tagged.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
buildtools/meson.build | 2 ++
lib/meson.build | 12 +++++++++++-
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/buildtools/meson.build b/buildtools/meson.build
index 32c79c130..8d0b9e0cd 100644
--- a/buildtools/meson.build
+++ b/buildtools/meson.build
@@ -5,6 +5,8 @@ subdir('pmdinfogen')
pmdinfo = find_program('gen-pmdinfo-cfile.sh')
+check_experimental_syms = find_program('check-experimental-syms.sh')
+
# set up map-to-def script using python, either built-in or external
python3 = import('python').find_installation(required: false)
if python3.found()
diff --git a/lib/meson.build b/lib/meson.build
index e5ff83893..5be5c8559 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -128,11 +128,21 @@ foreach l:libraries
command: [map_to_def_cmd, '@INPUT@', '@OUTPUT@'],
input: version_map,
output: 'rte_@0@_exports.def'.format(name))
+ lk_deps = [version_map, def_file]
if is_windows
lk_args = ['-Wl,/def:' + def_file.full_path(),
'-Wl,/implib:lib\\' + implib]
else
lk_args = ['-Wl,--version-script=' + version_map]
+ # on unix systems check the output of the
+ # experimental syms script, using it as a
+ # dependency of the .so build
+ lk_deps += custom_target(name + '.exp_chk',
+ command: [check_experimental_syms,
+ version_map, '@INPUT@'],
+ capture: true,
+ input: static_lib,
+ output: name + '.exp_chk')
endif
shared_lib = shared_library(libname,
@@ -142,7 +152,7 @@ foreach l:libraries
dependencies: shared_deps,
include_directories: includes,
link_args: lk_args,
- link_depends: [version_map, def_file],
+ link_depends: lk_deps,
version: lib_version,
soversion: so_version,
install: true)
--
2.21.0
next prev parent reply other threads:[~2019-10-08 14:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 14:36 [dpdk-dev] [PATCH 0/3] Add scanning for experimental symbols to meson Bruce Richardson
2019-10-08 14:36 ` [dpdk-dev] [PATCH 1/3] check-experimental-syms: remove use of environmental var Bruce Richardson
2019-10-08 14:36 ` Bruce Richardson [this message]
2019-10-08 14:36 ` [dpdk-dev] [PATCH 3/3] drivers: process shared lib link dependencies as for libs Bruce Richardson
2019-10-09 8:17 ` [dpdk-dev] [PATCH 0/3] Add scanning for experimental symbols to meson Luca Boccassi
2019-11-09 20:23 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191008143628.46054-3-bruce.richardson@intel.com \
--to=bruce.richardson@intel.com \
--cc=bluca@debian.org \
--cc=dev@dpdk.org \
--cc=nhorman@tuxdriver.com \
--cc=ray.kinsella@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).