From: Stephen Hemminger <stephen@networkplumber.org>
To: "Morten Brørup" <mb@smartsharesystems.com>
Cc: olivier.matz@6wind.com, harry.van.haaren@intel.com,
konstantin.ananyev@intel.com, mattias.ronnblom@ericsson.com,
bruce.richardson@intel.com, arybchenko@solarflare.com,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v5 1/1] mbuf: add bulk free function
Date: Wed, 9 Oct 2019 15:54:41 -0700 [thread overview]
Message-ID: <20191009155441.5ecd1ae0@hermes.lan> (raw)
In-Reply-To: <20191009135511.84547-2-mb@smartsharesystems.com>
On Wed, 9 Oct 2019 13:55:11 +0000
Morten Brørup <mb@smartsharesystems.com> wrote:
>
> +/**
> + * @internal helper function for freeing a bulk of packet mbuf segments
> + * via an array holding the packet mbuf segments from the same mempool
> + * pending to be freed.
> + *
> + * @param m
> + * The packet mbuf segment to be freed.
> + * @param pending
> + * Pointer to the array of packet mbuf segments pending to be freed.
> + * @param nb_pending
> + * Pointer to the number of elements held in the array.
> + * @param pending_sz
> + * Number of elements the array can hold.
> + * Note: The compiler should optimize this parameter away when using a
> + * constant value, such as RTE_PKTMBUF_FREE_PENDING_SZ.
> + */
> +static __rte_always_inline void
> +__rte_pktmbuf_free_seg_via_array(struct rte_mbuf *m,
Overall the patch looks good, but don't think always_inline
is required here. That should be reserved for things that use
inline assembly or other stuff that would be broken if it wasn't
inlined.
Most compilers would inline it without any modifier anyway.
next prev parent reply other threads:[~2019-10-09 22:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 13:55 [dpdk-dev] [PATCH v5 0/1] " Morten Brørup
2019-10-09 13:55 ` [dpdk-dev] [PATCH v5 1/1] " Morten Brørup
2019-10-09 22:54 ` Stephen Hemminger [this message]
2019-10-10 6:25 ` Andrew Rybchenko
2019-10-10 0:01 ` Ananyev, Konstantin
2019-10-10 8:33 ` [dpdk-dev] [PATCH v6 0/2] " Morten Brørup
2019-10-10 8:33 ` [dpdk-dev] [PATCH v6 1/2] " Morten Brørup
2019-10-10 8:33 ` [dpdk-dev] [PATCH v6 2/2] " Morten Brørup
2019-10-10 8:49 ` [dpdk-dev] [PATCH v6 0/2] " Morten Brørup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191009155441.5ecd1ae0@hermes.lan \
--to=stephen@networkplumber.org \
--cc=arybchenko@solarflare.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=mattias.ronnblom@ericsson.com \
--cc=mb@smartsharesystems.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).