From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC173A3160 for ; Thu, 10 Oct 2019 16:52:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4A5D61E9F1; Thu, 10 Oct 2019 16:52:01 +0200 (CEST) Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 492141E9ED for ; Thu, 10 Oct 2019 16:52:00 +0200 (CEST) Received: by mail-pg1-f196.google.com with SMTP id u12so3814916pgb.11 for ; Thu, 10 Oct 2019 07:52:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LTL6pq15cBg7MCvQzQs0KKEYaI+62/SvsGyH7iDq/kE=; b=lv8p5NXTUI+j/MelDVmZuj+K3IJncGtKyEtDISk2grnlv1y79AHdoE4u+MDzJiC+oe ilQTi+89fH2cffN0IgVZNaIpfZmh2w8T4D3K2cowrITXtwLqznkD2NM8O/QQwwyFtcP9 x4IQyuKl9vu6MUi5IBQCC7z/5aa/iwgwvL4lck81lfROcDzZgTi4qvwD6ORI0C0nsTNp kBej+iQJAvZaoT7EJ9lpcNmAePx0fUQhL82CdPD7+5klvD7Qz6uMkJSht67pDjD+7x0t unUwWYTSbYvipOJnfeG2OrEQG00osrblVJP7P4qlnwChvOPU/5VfUT9XT1wVb4+lGAXS bCmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LTL6pq15cBg7MCvQzQs0KKEYaI+62/SvsGyH7iDq/kE=; b=qj80a/dwHOgn8YG2/XxGpMbPz/Fqq6liUHthZEcAJgi3WoX3UNuSCblcTwtgqB4t6i 2OGFEqdF+fW/vnxxRTJRJBG9cs06xQhBIhKiJBtsMwE6wzNfw7sl2e6t/gHCkIycBPqT bJmv/r5rr915SEwQd4JMWlIZH0a9NM3TAKc9FRT6uNFuFH2Kh/audwJ1jycMSqKqSB9i nR9DbLphd4LMg/NUZZr8KYblSW65eLYAz+AO+//GHaEfw06A8GtatISxXPfRAjWIPAzN eYhKWR7CdyskWBVxB/n+L7w+TSQs5Aj+2xnd3cqGS5/kKpEwHvBNatrPHwDBpGAM5P1G vtGg== X-Gm-Message-State: APjAAAUlfQjl6gNdCsW4s9DMbGB+cRqTQ9HAis3eZdRqCD1gX1cSyx6N mit3JgCqdJ32osB9w730beSgnA== X-Google-Smtp-Source: APXvYqwHkgWKc9NyPqle9vay1IHEpgWEkcc1GafubA6hvdCCho1DPk64OlBsTd6DUT1w5/pT8luidw== X-Received: by 2002:a63:7845:: with SMTP id t66mr11369298pgc.31.1570719119210; Thu, 10 Oct 2019 07:51:59 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id a16sm7485948pfa.53.2019.10.10.07.51.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Oct 2019 07:51:59 -0700 (PDT) Date: Thu, 10 Oct 2019 07:51:52 -0700 From: Stephen Hemminger To: Morten =?UTF-8?B?QnLDuHJ1cA==?= Cc: olivier.matz@6wind.com, harry.van.haaren@intel.com, konstantin.ananyev@intel.com, mattias.ronnblom@ericsson.com, bruce.richardson@intel.com, arybchenko@solarflare.com, dev@dpdk.org Message-ID: <20191010075152.2737bbbc@hermes.lan> In-Reply-To: <20191010082621.45899-3-mb@smartsharesystems.com> References: <20191010082621.45899-1-mb@smartsharesystems.com> <20191010082621.45899-3-mb@smartsharesystems.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v6 2/2] mbuf: add bulk free function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 10 Oct 2019 08:26:21 +0000 Morten Br=C3=B8rup wrote: > Add function for freeing a bulk of mbufs. >=20 > v6: > * Remove __rte_always_inline from static function. > The compiler will inline anyway. > v5: > * Rename variables from "free" to "pending" for improved readability. > * Add prefix __ to rte_pktmbuf_free_seg_via_array(). > * Add array size parameter to __rte_pktmbuf_free_seg_via_array(). > The compiler will optimize the parameter away anyway. > * Add description to __rte_pktmbuf_free_seg_via_array(). > * Minor description updates. > v4: > * Mark as experimental by adding __rte_experimental. > * Add function to experimental section of map file. > * Fix source code formatting regarding pointer to pointer. > * Squash multiple modifications into one. > v3: > * Bugfix: Handle pakets with multiple segments. > * Add inline helper function, mainly for readability. > * Fix source code formatting regarding indentation. > v2: > * Function is not inline. > * Optimize to free multible mbufs belonging to the same mempool in > bulk. Inspired by ixgbe_tx_free_bufs(), but allowing NULL pointers > in the array, just like rte_pktmbuf_free() can take a NULL pointer. > * Use unsigned int instead of unsigned. Passes checkpatch, but > mismatches the original coding style of the modified files. > * Fix a typo in the description headline: mempools is plural. >=20 > Signed-off-by: Morten Br=C3=B8rup These two could be squashed together when merged Acked-by: Stephen Hemminger