From: "Morten Brørup" <mb@smartsharesystems.com>
To: dev@dpdk.org
Cc: olivier.matz@6wind.com, stephen@networkplumber.org,
harry.van.haaren@intel.com, konstantin.ananyev@intel.com,
mattias.ronnblom@ericsson.com, bruce.richardson@intel.com,
arybchenko@solarflare.com,
"Morten Brørup" <mb@smartsharesystems.com>
Subject: [dpdk-dev] [PATCH v6 2/2] mbuf: add bulk free function
Date: Thu, 10 Oct 2019 09:34:56 +0000 [thread overview]
Message-ID: <20191010093456.47037-3-mb@smartsharesystems.com> (raw)
In-Reply-To: <20191010093456.47037-1-mb@smartsharesystems.com>
Add function for freeing a bulk of mbufs.
Signed-off-by: Morten Brørup <mb@smartsharesystems.com>
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
v6:
* Remove __rte_always_inline from static function.
The compiler will inline anyway.
v5:
* Rename variables from "free" to "pending" for improved readability.
* Add prefix __ to rte_pktmbuf_free_seg_via_array().
* Add array size parameter to __rte_pktmbuf_free_seg_via_array().
The compiler will optimize the parameter away anyway.
* Add description to __rte_pktmbuf_free_seg_via_array().
* Minor description updates.
v4:
* Mark as experimental by adding __rte_experimental.
* Add function to experimental section of map file.
* Fix source code formatting regarding pointer to pointer.
* Squash multiple modifications into one.
v3:
* Bugfix: Handle pakets with multiple segments.
* Add inline helper function, mainly for readability.
* Fix source code formatting regarding indentation.
v2:
* Function is not inline.
* Optimize to free multible mbufs belonging to the same mempool in
bulk. Inspired by ixgbe_tx_free_bufs(), but allowing NULL pointers
in the array, just like rte_pktmbuf_free() can take a NULL pointer.
* Use unsigned int instead of unsigned. Passes checkpatch, but
mismatches the original coding style of the modified files.
* Fix a typo in the description headline: mempools is plural.
---
lib/librte_mbuf/rte_mbuf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c
index de5659baa..854af1104 100644
--- a/lib/librte_mbuf/rte_mbuf.c
+++ b/lib/librte_mbuf/rte_mbuf.c
@@ -261,7 +261,7 @@ int rte_mbuf_check(const struct rte_mbuf *m, int is_header,
* Note: The compiler should optimize this parameter away when using a
* constant value, such as RTE_PKTMBUF_FREE_PENDING_SZ.
*/
-static __rte_always_inline void
+static void
__rte_pktmbuf_free_seg_via_array(struct rte_mbuf *m,
struct rte_mbuf ** const pending, unsigned int * const nb_pending,
const unsigned int pending_sz)
--
2.17.1
next prev parent reply other threads:[~2019-10-10 9:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 9:34 [dpdk-dev] [PATCH v6 0/2] " Morten Brørup
2019-10-10 9:34 ` [dpdk-dev] [PATCH v6 1/2] " Morten Brørup
2019-10-10 14:13 ` Morten Brørup
2019-10-10 16:13 ` [dpdk-dev] [dpdk-ci] " Jeremy Plsek
2019-10-10 16:28 ` [dpdk-dev] " Ananyev, Konstantin
2019-10-10 9:34 ` Morten Brørup [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-10-10 8:26 [dpdk-dev] [PATCH v6 0/2] " Morten Brørup
2019-10-10 8:26 ` [dpdk-dev] [PATCH v6 2/2] " Morten Brørup
2019-10-10 14:51 ` Stephen Hemminger
2019-10-09 13:55 [dpdk-dev] [PATCH v5 1/1] " Morten Brørup
2019-10-10 8:33 ` [dpdk-dev] [PATCH v6 0/2] " Morten Brørup
2019-10-10 8:33 ` [dpdk-dev] [PATCH v6 2/2] " Morten Brørup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191010093456.47037-3-mb@smartsharesystems.com \
--to=mb@smartsharesystems.com \
--cc=arybchenko@solarflare.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=mattias.ronnblom@ericsson.com \
--cc=olivier.matz@6wind.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).