From: Ciara Power <ciara.power@intel.com>
To: bruce.richardson@intel.com
Cc: dev@dpdk.org, Ciara Power <ciara.power@intel.com>
Subject: [dpdk-dev] [PATCH 2/2] raw/ioat: fix initial ring size check
Date: Thu, 10 Oct 2019 13:36:03 +0100 [thread overview]
Message-ID: <20191010123603.58007-3-ciara.power@intel.com> (raw)
In-Reply-To: <20191010123603.58007-1-ciara.power@intel.com>
When running the ioat_rawdev_autotest, the ring size was initially required
to be 0. This prevented the test being run multiple times, as the ring size
is modified to a non-zero value when running the first test.
A global variable is now used to track the expected ring size, and is used
in the initial value check. This enables the test to be run more than
once.
Fixes: 849470d522ed ("raw/ioat: add configure, start and stop functions")
Cc: bruce.richardson@intel.com
Reported-by: Yinan Wang <yinan.wang@intel.com>
Signed-off-by: Ciara Power <ciara.power@intel.com>
---
drivers/raw/ioat/ioat_rawdev_test.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/raw/ioat/ioat_rawdev_test.c b/drivers/raw/ioat/ioat_rawdev_test.c
index 6aad79486..e99f97ec4 100644
--- a/drivers/raw/ioat/ioat_rawdev_test.c
+++ b/drivers/raw/ioat/ioat_rawdev_test.c
@@ -11,6 +11,7 @@
int ioat_rawdev_test(uint16_t dev_id); /* pre-define to keep compiler happy */
static struct rte_mempool *pool;
+static unsigned short expected_ring_size;
static int
test_enqueue_copies(int dev_id)
@@ -148,9 +149,9 @@ ioat_rawdev_test(uint16_t dev_id)
unsigned int i;
rte_rawdev_info_get(dev_id, &info);
- if (p.ring_size != 0) {
- printf("Error, initial ring size is non-zero (%d)\n",
- (int)p.ring_size);
+ if (p.ring_size != expected_ring_size) {
+ printf("Error, initial ring size is not as expected (Actual: %d, Expected: %d)\n",
+ (int)p.ring_size, expected_ring_size);
return -1;
}
@@ -165,6 +166,7 @@ ioat_rawdev_test(uint16_t dev_id)
IOAT_TEST_RINGSIZE, (int)p.ring_size);
return -1;
}
+ expected_ring_size = p.ring_size;
if (rte_rawdev_start(dev_id) != 0) {
printf("Error with rte_rawdev_start()\n");
--
2.17.1
next prev parent reply other threads:[~2019-10-10 12:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 12:36 [dpdk-dev] [PATCH 0/2] enable ioat test to run multiple times Ciara Power
2019-10-10 12:36 ` [dpdk-dev] [PATCH 1/2] raw/ioat: fix rawdev state to stopped after test Ciara Power
2019-10-10 12:40 ` Bruce Richardson
2019-10-10 12:36 ` Ciara Power [this message]
2019-10-10 12:40 ` [dpdk-dev] [PATCH 2/2] raw/ioat: fix initial ring size check Bruce Richardson
2019-10-27 13:22 ` [dpdk-dev] [PATCH 0/2] enable ioat test to run multiple times David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191010123603.58007-3-ciara.power@intel.com \
--to=ciara.power@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).