From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C4C1A2EFC for ; Mon, 14 Oct 2019 10:27:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C76B61C124; Mon, 14 Oct 2019 10:27:17 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id BB8B11C030 for ; Mon, 14 Oct 2019 10:27:15 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Oct 2019 01:27:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,295,1566889200"; d="scan'208";a="194162076" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by fmsmga008.fm.intel.com with ESMTP; 14 Oct 2019 01:27:14 -0700 Date: Mon, 14 Oct 2019 16:24:38 +0800 From: Ye Xiaolong To: Haiyue Wang Cc: dev@dpdk.org Message-ID: <20191014082438.GD3725@intel.com> References: <20191009130716.80418-1-haiyue.wang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191009130716.80418-1-haiyue.wang@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v1] net/ice: avoid the parsed devargs value being overwritten X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/09, Haiyue Wang wrote: >If the default dev args 'proto_xtr' is not in the first position, it >will overwrite the parsed queue map value, so use an new variable to >save the default. > >And enhance the error message printing to show the right information. > >Signed-off-by: Haiyue Wang >--- > drivers/net/ice/ice_ethdev.c | 44 +++++++++++++++++++++++++----------- > drivers/net/ice/ice_ethdev.h | 1 + > 2 files changed, 32 insertions(+), 13 deletions(-) > [snip] >@@ -2126,6 +2142,8 @@ ice_dev_close(struct rte_eth_dev *dev) > rte_free(hw->port_info); > hw->port_info = NULL; > ice_shutdown_all_ctrlq(hw); >+ rte_free(pf->proto_xtr); >+ pf->proto_xtr = NULL; These two lines seems irrelevant to this patch, I noticed that the resource free operation was contained in the original patch, and they are removed unexpectedly by commit bd513ece3c40 ("net/ice: release port upon close"), sorry for not catching it when reviewing. Prefer one individual patch for the fix. Thanks, Xiaolong > > dev->dev_ops = NULL; > dev->rx_pkt_burst = NULL; >diff --git a/drivers/net/ice/ice_ethdev.h b/drivers/net/ice/ice_ethdev.h >index 182c6f611..2fd98817b 100644 >--- a/drivers/net/ice/ice_ethdev.h >+++ b/drivers/net/ice/ice_ethdev.h >@@ -288,6 +288,7 @@ struct ice_pf { > */ > struct ice_devargs { > int safe_mode_support; >+ uint8_t proto_xtr_dflt; > uint8_t proto_xtr[ICE_MAX_QUEUE_NUM]; > }; > >-- >2.17.1 >