From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1E4FDA2EFC for ; Mon, 14 Oct 2019 17:16:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D137F1C115; Mon, 14 Oct 2019 17:16:41 +0200 (CEST) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 306CE1C0C4 for ; Mon, 14 Oct 2019 17:16:40 +0200 (CEST) Received: by mail-wr1-f66.google.com with SMTP id r5so20147232wrm.12 for ; Mon, 14 Oct 2019 08:16:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=YgeQb2XIKgTkgLTkFS9GiXCYB0L73n3xWjZ8TgEqV1Y=; b=F/5qhMfOBWTXeDlDxGvOWtVr0SEiCt/xeGlWlAnV+YQQNcj0ZgfW5dKOD2IYT8JkF5 SyRB4TU4Jep28B7R3kwSqvpkNSvUi9K4/A5ZKUhKKMYuN7ybvjjcQ27VR7473LQDhYHk ue98oxZk7efvX3ESYw3aC4/sBC0Zo105k5dBwlkPZYiZ33NX8q0kGZSb/ABobQ2fFmzz 6ik4wswrQmEk4dvHKUJOSPP1zOequWAZJoCFr0sLFrU93r6wKCE1MEsWkYgGRrhi4Tfz oefTqrICFcjxIEYCy0k+GeeDsbEMyEseb7YhW1BjDRAzH3eriNfYEXQMfqbSDTz6mPIT BcfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=YgeQb2XIKgTkgLTkFS9GiXCYB0L73n3xWjZ8TgEqV1Y=; b=SZzsh8fQqW30QIzFgsGpXxAye9lV4roQbZdw3sZyb9wsxW0r/UmHfh0BpzTGWGGpAA h4+efH8pbEjHjV+Pi37G+1auNEsd0jpRl5J9OHqTW7N32GRbA7aLXOO133nw2KQ9eDvJ B5TYpDsChGOKrhSyXwh1fGcmANVcv/GKKN79lXA9ko5NCpPtTRO/UXWJ9iapDgwVPZUB RopzZFwpmAhc0UgByelnkgBr7RN0mcTzKybcjonpso9bBxz03hFMMtXM4dComvy28v17 VmHYocC2fGXV3hou1BV0zr+GT/cz/Q577WeFLjUAoAJEgQRlnRGPBPwheKuHntw5QU62 nhuw== X-Gm-Message-State: APjAAAUOU292ox9Dk9AWTDrk9oFwi3LhzoRR1umNVBlfLAvs/0Xv2isI U3xvv5ZA2ioPnJ1Plu895qkFYS7J4/0= X-Google-Smtp-Source: APXvYqzdzg25/EciRCX3WiFUl/VEx1pE9lQ5W45zB7emOaVWO65vtVRhUjV8v2IrItlgcjxR5FSmJw== X-Received: by 2002:a5d:5052:: with SMTP id h18mr18555472wrt.143.1571066199825; Mon, 14 Oct 2019 08:16:39 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id f143sm31572886wme.40.2019.10.14.08.16.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 14 Oct 2019 08:16:39 -0700 (PDT) Date: Mon, 14 Oct 2019 17:16:37 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: David Marchand Cc: dev , dariusz.stojaszyk@intel.com, Seth Howell Message-ID: <20191014151637.ihhyqzfmsz2mvyds@bidouze.vm.6wind.com> References: <20191011205607.1743460-1-seth.howell@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH] rte_bus_pci: remove unneeded library dependency. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Oct 14, 2019 at 04:32:54PM +0200, David Marchand wrote: > On Fri, Oct 11, 2019 at 10:56 PM Seth Howell wrote: > > > > The makefile in drivers/bus/pci specified rte_ethdev as a dependency for > > the library. However there are no actual symbols from librte_ethdev used > > in librte_bus_pci. > > > > Including librte_ethdev as a dependency only becomes a problem in some > > niche cases like when attempting to build the rte_bus_pci library as a > > shared object without building the rte_ethdev library. > > > > I specifically ran into this when trying to build the DPDK included as > > an SPDK submodule on a FreeBSD machine. I figure that since there are no > > real dependencies between the two, we should enable building > > librte_bus_pci without librte_ethdev. > > > > Signed-off-by: Seth Howell > > --- > > drivers/bus/pci/Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/bus/pci/Makefile b/drivers/bus/pci/Makefile > > index 68c1f3fde..45d12427a 100644 > > --- a/drivers/bus/pci/Makefile > > +++ b/drivers/bus/pci/Makefile > > @@ -25,7 +25,7 @@ CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common > > CFLAGS += -DALLOW_EXPERIMENTAL_API > > > > LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring > > -LDLIBS += -lrte_ethdev -lrte_pci -lrte_kvargs > > +LDLIBS += -lrte_pci -lrte_kvargs > > > > include $(RTE_SDK)/drivers/bus/pci/$(SYSTEM)/Makefile > > SRCS-$(CONFIG_RTE_LIBRTE_PCI_BUS) := $(addprefix $(SYSTEM)/,$(SRCS)) > > -- > > 2.17.2 > > > > At a first glance, this patch seems valid, Gaëtan, could you have a look ? > Could be worth a Fixes:. > > Thanks. > > > -- > David Marchand > Hi, Yes this is fine. I've checked, when this Makefile was introduced first in v17.11, this dependency was not needed either. This means the Fixes: can go back to c752998b5. Acked-by: Gaetan Rivet -- Gaëtan Rivet 6WIND