From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B7D03A3168 for ; Wed, 16 Oct 2019 06:20:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 71D441C1E6; Wed, 16 Oct 2019 06:20:19 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 660161C1DD; Wed, 16 Oct 2019 06:20:17 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Oct 2019 21:20:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,302,1566889200"; d="scan'208";a="370683374" Received: from dpdk-virtio-tbie-2.sh.intel.com (HELO ___) ([10.67.104.74]) by orsmga005.jf.intel.com with ESMTP; 15 Oct 2019 21:20:15 -0700 Date: Wed, 16 Oct 2019 12:17:13 +0800 From: Tiwei Bie To: Andrew Rybchenko Cc: Maxime Coquelin , Zhihong Wang , dev@dpdk.org, stable@dpdk.org Message-ID: <20191016041713.GA29004@___> References: <1571127088-26656-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1571127088-26656-1-git-send-email-arybchenko@solarflare.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/virtio: fix broken transmit functionality X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 15, 2019 at 09:11:27AM +0100, Andrew Rybchenko wrote: > Previous fix removes usage of rte_pktmbuf_prepend() to get pointer > to virtio net header which changes mbuf data_off and data_len. > Size of virtio net header is added to segment length when Tx descriptor > is composed, but segment address (calculated using data_off) is not > adjusted to take size of virtio net header into account. > > Fixes: c100fc6849fb ("net/virtio: fix mbuf data and pkt length mismatch") The commit in main branch is: Fixes: 1ae55ad38e5e ("net/virtio: fix mbuf data and packet length mismatch") For the rest, Reviewed-by: Tiwei Bie