From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Leyi Rong <leyi.rong@intel.com>
Cc: wenzhuo.lu@intel.com, qi.z.zhang@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] net/ice: invoke callback func when link status change
Date: Wed, 16 Oct 2019 14:41:18 +0800 [thread overview]
Message-ID: <20191016064118.GP3725@intel.com> (raw)
In-Reply-To: <20191016062446.18001-1-leyi.rong@intel.com>
On 10/16, Leyi Rong wrote:
>Needs to call _rte_eth_dev_callback_process to run registered
>callbacks when link status change.
>
Is it a must to call _rte_eth_dev_callback_process after link status change, I
see ice_link_update is also called in ice_dev_start, do we need to apply the
same change there too?
Thanks,
Xiaolong
>Fixes: cf911d90e366 ("net/ice: support link update")
>
>Signed-off-by: Leyi Rong <leyi.rong@intel.com>
>
>---
>v2:
>- adds fixline in commit log.
>---
> drivers/net/ice/ice_ethdev.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
>index 5567beb55..092f10d47 100644
>--- a/drivers/net/ice/ice_ethdev.c
>+++ b/drivers/net/ice/ice_ethdev.c
>@@ -1303,6 +1303,7 @@ ice_interrupt_handler(void *param)
> uint8_t pf_num;
> uint8_t event;
> uint16_t queue;
>+ int ret;
> #ifdef ICE_LSE_SPT
> uint32_t int_fw_ctl;
> #endif
>@@ -1330,7 +1331,10 @@ ice_interrupt_handler(void *param)
> #else
> if (oicr & PFINT_OICR_LINK_STAT_CHANGE_M) {
> PMD_DRV_LOG(INFO, "OICR: link state change event");
>- ice_link_update(dev, 0);
>+ ret = ice_link_update(dev, 0);
>+ if (!ret)
>+ _rte_eth_dev_callback_process
>+ (dev, RTE_ETH_EVENT_INTR_LSC, NULL);
> }
> #endif
>
>--
>2.17.1
>
next prev parent reply other threads:[~2019-10-16 6:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 8:41 [dpdk-dev] [PATCH] " Leyi Rong
2019-10-16 5:41 ` Ye Xiaolong
2019-10-16 6:24 ` [dpdk-dev] [PATCH v2] " Leyi Rong
2019-10-16 6:41 ` Ye Xiaolong [this message]
2019-10-16 7:08 ` Rong, Leyi
2019-10-17 3:16 ` Ye Xiaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191016064118.GP3725@intel.com \
--to=xiaolong.ye@intel.com \
--cc=dev@dpdk.org \
--cc=leyi.rong@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).