From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2FE5BA56D4 for ; Wed, 16 Oct 2019 21:05:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CF1841E990; Wed, 16 Oct 2019 21:05:17 +0200 (CEST) Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by dpdk.org (Postfix) with ESMTP id 042FA1E953 for ; Wed, 16 Oct 2019 21:05:15 +0200 (CEST) Received: by mail-pl1-f193.google.com with SMTP id j11so11711259plk.3 for ; Wed, 16 Oct 2019 12:05:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eik/crz+bWU/rgCvnEQrnh85WClE77Z9O8ybl0HEdSk=; b=QORh82EIpI5ko4HVW7HmeMsqvRKuqIhMpxrPZ3yTDRlhzALN2r5s7tbgC+PxiZG9Be nZ7YzVcZNjQi568d0s25tsTTdDU2KjtK76PIgsuciDdOx7Mt7AORHt/YMr8DFxXpmSgD OW+UmPh8fYftroBKXg/JlYYY/bDh9J4bKqBtlb8fRwtN/+lkzQ67wNKAdtZaMNNqM4Dr 884fvYKLJt0bQksRZB4K7sQyTQHp6xnox1rLRba00u1Fq/i8J8eaq58lRCIb1w9EjjER MWvj+IL/IBBtnsk1Zovc8pfb/EL1nO7DrzFics5znkI+3YoZg6DLGCd+mCNvcfeOmV9h /zGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eik/crz+bWU/rgCvnEQrnh85WClE77Z9O8ybl0HEdSk=; b=pHCKM9VfPOW4ymkh5buqjBfySiQCU2ylncwlJaOGaN0nU4BpBRjcExeTotbqi8UVOX YTttpF1cS0WHmQZaKjKyRN+A2o3oI1KdK6GKEASb1TC7wPFzsnpvvbiNg51NS+cVV6ea eWnIkLfg/tbHsk1TA79eYKKnej7siuTltCQOF3jILNUCvX3EaF3kUTVI4sJGg48OBHwW 1rGa/iA0JSKq+WVvnCh7WJH9ZSeSVok6pDiDjBNMBB7pbvO+RG6uA7IcJeA6dzIgYnCM ytX3xNAjnn/B5oogwBxzsEObk4n9bYTFE4nY/Hgo52O5TA7r2PbhqNeu6Kya2haDoFcX 7Duw== X-Gm-Message-State: APjAAAWy6bhXa3lzX7n/TQdXA/SM9CR77/81WXrWwmN4Qc+foUIbwKmV a/qvGfoewnaTFFx6CY6HELPA3w== X-Google-Smtp-Source: APXvYqwIGhWW3frLfZDjZTK3XXfvgHpvtNuV7hk+HTwPijPZievlvhzcEKSCfdEBp+dzhmxQ54FEUw== X-Received: by 2002:a17:902:47:: with SMTP id 65mr42394764pla.81.1571252715103; Wed, 16 Oct 2019 12:05:15 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id s3sm3460388pjq.32.2019.10.16.12.05.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Oct 2019 12:05:15 -0700 (PDT) Date: Wed, 16 Oct 2019 12:05:12 -0700 From: Stephen Hemminger To: Joyce Kong Cc: dev@dpdk.org, nd@arm.com, thomas@monjalon.net, jerinj@marvell.com, ravi1.kumar@amd.com, xuanziyang2@huawei.com, cloud.wangxiaoyun@huawei.com, zhouguoyang@huawei.com, rmody@marvell.com, shshaikh@marvell.com, honnappa.nagarahalli@arm.com, gavin.hu@arm.com Message-ID: <20191016120512.3e08329a@hermes.lan> In-Reply-To: <1571125801-45773-2-git-send-email-joyce.kong@arm.com> References: <1571125801-45773-1-git-send-email-joyce.kong@arm.com> <1571125801-45773-2-git-send-email-joyce.kong@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v1 1/5] lib/eal: implement the family of rte bit operation APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 15 Oct 2019 15:49:57 +0800 Joyce Kong wrote: > There are a lot functions of bit operations scattered and > duplicated in PMDs, consolidating them into a common API > family is necessary. Furthermore, the bit operation is > mostly applied to the IO devices, so use __ATOMIC_ACQ_REL > to ensure the ordering. > > Signed-off-by: Joyce Kong 'include/rte_common.h', Patchwork reports several build failures for this patch set. /tmp/UB1604-64_K4.4.0_Clang3.8.0/x86_64-native-linuxapp-clang/62c86b2c1091439598f2f1688566632c/dpdk/x86_64-native-linuxapp-clang/lib/librte_pmd_bnx2x.a(bnx2x.o): In function `bnx2x_set_storm_rx_mode': /tmp/UB1604-64_K4.4.0_Clang3.8.0/x86_64-native-linuxapp-clang/62c86b2c1091439598f2f1688566632c/dpdk/drivers/net/bnx2x/bnx2x.c:(.text+0x1602): undefined reference to `ret_set_bit'