From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 42711A3168 for ; Thu, 17 Oct 2019 06:46:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 85FEB1DFE6; Thu, 17 Oct 2019 06:46:12 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id DAE191DFE3 for ; Thu, 17 Oct 2019 06:46:10 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Oct 2019 21:46:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,306,1566889200"; d="scan'208";a="202276991" Received: from dpdk-virtio-tbie-2.sh.intel.com (HELO ___) ([10.67.104.74]) by FMSMGA003.fm.intel.com with ESMTP; 16 Oct 2019 21:46:08 -0700 Date: Thu, 17 Oct 2019 12:43:06 +0800 From: Tiwei Bie To: Ilya Maximets Cc: dev@dpdk.org, Maxime Coquelin , Flavio Leitner , David Marchand Message-ID: <20191017044306.GA17429@___> References: <20191016143107.10424-1-i.maximets@ovn.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191016143107.10424-1-i.maximets@ovn.org> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] vhost: return error message for mbuf allocation failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 16, 2019 at 04:31:07PM +0200, Ilya Maximets wrote: > mbuf allocation failure is a hard failure that highlights some > significant issues with memory pool size or a mbuf leak. > > We still have the message for subsequent chained mbufs, but not > for the first one. It was removed while introducing extbuf > support for large buffers. But it was useful for catching > mempool issues and needs to be returned back. > > Cc: Flavio Leitner > > Fixes: 5005bcda7123 ("vhost: add support for large buffers") > Signed-off-by: Ilya Maximets > --- > lib/librte_vhost/virtio_net.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) Reviewed-by: Tiwei Bie Thanks, Tiwei