From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D522A3168 for ; Thu, 17 Oct 2019 07:49:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DA2A21E544; Thu, 17 Oct 2019 07:49:18 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 00F4B1E53A for ; Thu, 17 Oct 2019 07:49:16 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Oct 2019 22:49:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,306,1566889200"; d="scan'208";a="397410843" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by fmsmga006.fm.intel.com with ESMTP; 16 Oct 2019 22:49:06 -0700 Date: Thu, 17 Oct 2019 13:46:20 +0800 From: Ye Xiaolong To: Qi Zhang Cc: qiming.yang@intel.com, dev@dpdk.org, Dan Nowlin , Paul M Stillwell Jr Message-ID: <20191017054620.GU3725@intel.com> References: <20191017051854.41066-1-qi.z.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191017051854.41066-1-qi.z.zhang@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/ice/base: fix for FDIR QFI offset in GTP protocol X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/17, Qi Zhang wrote: >For the GTP protocol, the QFI offset used by to create the field vector >was off by one byte. This patch corrects that offset. > >Fixes: febb0f877f6e ("net/ice/base: add QFI for flow director") > >Signed-off-by: Dan Nowlin >Signed-off-by: Paul M Stillwell Jr >Signed-off-by: Qi Zhang >--- > drivers/net/ice/base/ice_flow.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_flow.c >index f4f961167..d2dbb1177 100644 >--- a/drivers/net/ice/base/ice_flow.c >+++ b/drivers/net/ice/base/ice_flow.c >@@ -131,8 +131,8 @@ struct ice_flow_field_info ice_flds_info[ICE_FLOW_FIELD_IDX_MAX] = { > ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_GTPU_EH, 12, > ICE_FLOW_FLD_SZ_GTP_TEID), > /* ICE_FLOW_FIELD_IDX_GTPU_EH_QFI */ >- ICE_FLOW_FLD_INFO_MSK(ICE_FLOW_SEG_HDR_GTPU_EH, 20, >- ICE_FLOW_FLD_SZ_GTP_QFI, 0x003f), >+ ICE_FLOW_FLD_INFO_MSK(ICE_FLOW_SEG_HDR_GTPU_EH, 22, >+ ICE_FLOW_FLD_SZ_GTP_QFI, 0x3f00), > /* ICE_FLOW_FIELD_IDX_GTPU_UP_TEID */ > ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_GTPU_UP, 12, > ICE_FLOW_FLD_SZ_GTP_TEID), >-- >2.13.6 > Applied to dpdk-next-net-intel. Thanks, Xiaolong