* [dpdk-dev] [PATCH] net/ice/base: fix for FDIR QFI offset in GTP protocol
@ 2019-10-17 5:18 Qi Zhang
2019-10-17 5:46 ` Ye Xiaolong
0 siblings, 1 reply; 3+ messages in thread
From: Qi Zhang @ 2019-10-17 5:18 UTC (permalink / raw)
To: qiming.yang; +Cc: dev, Qi Zhang, Dan Nowlin, Paul M Stillwell Jr
For the GTP protocol, the QFI offset used by to create the field vector
was off by one byte. This patch corrects that offset.
Fixes: febb0f877f6e ("net/ice/base: add QFI for flow director")
Signed-off-by: Dan Nowlin <dan.nowlin@intel.com>
Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
drivers/net/ice/base/ice_flow.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_flow.c
index f4f961167..d2dbb1177 100644
--- a/drivers/net/ice/base/ice_flow.c
+++ b/drivers/net/ice/base/ice_flow.c
@@ -131,8 +131,8 @@ struct ice_flow_field_info ice_flds_info[ICE_FLOW_FIELD_IDX_MAX] = {
ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_GTPU_EH, 12,
ICE_FLOW_FLD_SZ_GTP_TEID),
/* ICE_FLOW_FIELD_IDX_GTPU_EH_QFI */
- ICE_FLOW_FLD_INFO_MSK(ICE_FLOW_SEG_HDR_GTPU_EH, 20,
- ICE_FLOW_FLD_SZ_GTP_QFI, 0x003f),
+ ICE_FLOW_FLD_INFO_MSK(ICE_FLOW_SEG_HDR_GTPU_EH, 22,
+ ICE_FLOW_FLD_SZ_GTP_QFI, 0x3f00),
/* ICE_FLOW_FIELD_IDX_GTPU_UP_TEID */
ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_GTPU_UP, 12,
ICE_FLOW_FLD_SZ_GTP_TEID),
--
2.13.6
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/ice/base: fix for FDIR QFI offset in GTP protocol
2019-10-17 5:18 [dpdk-dev] [PATCH] net/ice/base: fix for FDIR QFI offset in GTP protocol Qi Zhang
@ 2019-10-17 5:46 ` Ye Xiaolong
2019-10-17 10:39 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Ye Xiaolong @ 2019-10-17 5:46 UTC (permalink / raw)
To: Qi Zhang; +Cc: qiming.yang, dev, Dan Nowlin, Paul M Stillwell Jr
On 10/17, Qi Zhang wrote:
>For the GTP protocol, the QFI offset used by to create the field vector
>was off by one byte. This patch corrects that offset.
>
>Fixes: febb0f877f6e ("net/ice/base: add QFI for flow director")
>
>Signed-off-by: Dan Nowlin <dan.nowlin@intel.com>
>Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
>Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
>---
> drivers/net/ice/base/ice_flow.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_flow.c
>index f4f961167..d2dbb1177 100644
>--- a/drivers/net/ice/base/ice_flow.c
>+++ b/drivers/net/ice/base/ice_flow.c
>@@ -131,8 +131,8 @@ struct ice_flow_field_info ice_flds_info[ICE_FLOW_FIELD_IDX_MAX] = {
> ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_GTPU_EH, 12,
> ICE_FLOW_FLD_SZ_GTP_TEID),
> /* ICE_FLOW_FIELD_IDX_GTPU_EH_QFI */
>- ICE_FLOW_FLD_INFO_MSK(ICE_FLOW_SEG_HDR_GTPU_EH, 20,
>- ICE_FLOW_FLD_SZ_GTP_QFI, 0x003f),
>+ ICE_FLOW_FLD_INFO_MSK(ICE_FLOW_SEG_HDR_GTPU_EH, 22,
>+ ICE_FLOW_FLD_SZ_GTP_QFI, 0x3f00),
> /* ICE_FLOW_FIELD_IDX_GTPU_UP_TEID */
> ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_GTPU_UP, 12,
> ICE_FLOW_FLD_SZ_GTP_TEID),
>--
>2.13.6
>
Applied to dpdk-next-net-intel.
Thanks,
Xiaolong
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/ice/base: fix for FDIR QFI offset in GTP protocol
2019-10-17 5:46 ` Ye Xiaolong
@ 2019-10-17 10:39 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2019-10-17 10:39 UTC (permalink / raw)
To: Ye Xiaolong, Qi Zhang; +Cc: qiming.yang, dev, Dan Nowlin, Paul M Stillwell Jr
On 10/17/2019 6:46 AM, Ye Xiaolong wrote:
> On 10/17, Qi Zhang wrote:
>> For the GTP protocol, the QFI offset used by to create the field vector
>> was off by one byte. This patch corrects that offset.
>>
>> Fixes: febb0f877f6e ("net/ice/base: add QFI for flow director")
>>
>> Signed-off-by: Dan Nowlin <dan.nowlin@intel.com>
>> Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
>> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
>> ---
>> drivers/net/ice/base/ice_flow.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_flow.c
>> index f4f961167..d2dbb1177 100644
>> --- a/drivers/net/ice/base/ice_flow.c
>> +++ b/drivers/net/ice/base/ice_flow.c
>> @@ -131,8 +131,8 @@ struct ice_flow_field_info ice_flds_info[ICE_FLOW_FIELD_IDX_MAX] = {
>> ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_GTPU_EH, 12,
>> ICE_FLOW_FLD_SZ_GTP_TEID),
>> /* ICE_FLOW_FIELD_IDX_GTPU_EH_QFI */
>> - ICE_FLOW_FLD_INFO_MSK(ICE_FLOW_SEG_HDR_GTPU_EH, 20,
>> - ICE_FLOW_FLD_SZ_GTP_QFI, 0x003f),
>> + ICE_FLOW_FLD_INFO_MSK(ICE_FLOW_SEG_HDR_GTPU_EH, 22,
>> + ICE_FLOW_FLD_SZ_GTP_QFI, 0x3f00),
>> /* ICE_FLOW_FIELD_IDX_GTPU_UP_TEID */
>> ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_GTPU_UP, 12,
>> ICE_FLOW_FLD_SZ_GTP_TEID),
>> --
>> 2.13.6
>>
>
> Applied to dpdk-next-net-intel.
>
Squashed into relevant commit in next-net, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-17 10:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-17 5:18 [dpdk-dev] [PATCH] net/ice/base: fix for FDIR QFI offset in GTP protocol Qi Zhang
2019-10-17 5:46 ` Ye Xiaolong
2019-10-17 10:39 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).