From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 218D4A3168 for ; Thu, 17 Oct 2019 10:50:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A06E71E8C5; Thu, 17 Oct 2019 10:50:25 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 62A711E882 for ; Thu, 17 Oct 2019 10:50:24 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Oct 2019 01:50:23 -0700 X-IronPort-AV: E=Sophos;i="5.67,307,1566889200"; d="scan'208";a="200326937" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.95]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 17 Oct 2019 01:50:21 -0700 Date: Thu, 17 Oct 2019 09:50:18 +0100 From: Bruce Richardson To: Anatoly Burakov Cc: dev@dpdk.org, john.mcnamara@intel.com, thomas@monjalon.net, david.marchand@redhat.com Message-ID: <20191017085018.GB855@bricha3-MOBL.ger.corp.intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [dpdk-dev] [PATCH v3 0/9] Implement the new ABI policy and add helper scripts X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 16, 2019 at 06:03:35PM +0100, Anatoly Burakov wrote: > This patchset prepares the codebase for the new ABI policy and > adds a few helper scripts. > > There are two new scripts for managing ABI versions added. The > first one is a Python script that will read in a .map file, > flatten it and update the ABI version to the ABI version > specified on the command-line. > > The second one is a shell script that will run the above mentioned > Python script recursively over the source tree and set the ABI > version to either that which is defined in config/ABI_VERSION, or > a user-specified one. > > Example of its usage: buildtools/update-abi.sh 20.0 > > This will recurse into lib/ and drivers/ directory and update > whatever .map files it can find. > > The other shell script that's added is one that can take in a .so > file and ensure that its declared public ABI matches either > current ABI, next ABI, or EXPERIMENTAL. This was moved to the > last commit because it made no sense to have it beforehand. > > The source tree was verified to follow the new ABI policy using > the following command (assuming built binaries are in build/): > > find ./build/lib ./build/drivers -name \*.so \ > -exec ./buildtools/check-abi-version.sh {} \; -print > > This returns 0. > > Changes since v2: > - Addressed Bruce's review comments > - Removed single distributor mode as per Dave's suggestion > > Changes since v1: > - Reordered patchset to have removal of old ABI's before introducing > the new one to avoid compile breakages between patches > - Added a new patch fixing missing symbol in octeontx common > - Split script commits into multiple commits and reordered them > - Re-generated the ABI bump commit > - Verified all scripts to work > > Anatoly Burakov (2): > buildtools: add ABI update shell script > drivers/octeontx: add missing public symbol > > Marcin Baran (5): > config: change ABI versioning to global > timer: remove deprecated code > lpm: remove deprecated code > distributor: remove deprecated code > buildtools: add ABI versioning check script > > Pawel Modrak (2): > buildtools: add script for updating symbols abi version > build: change ABI version to 20.0 > For me, bar the one small open question on driver paths, this looks pretty good. Series-acked-by: Bruce Richardson