From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 46F49A317C for ; Thu, 17 Oct 2019 19:37:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B02AD1E887; Thu, 17 Oct 2019 19:37:23 +0200 (CEST) Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by dpdk.org (Postfix) with ESMTP id BDBEC1E887 for ; Thu, 17 Oct 2019 19:37:22 +0200 (CEST) Received: by mail-pg1-f193.google.com with SMTP id 23so1760915pgk.3 for ; Thu, 17 Oct 2019 10:37:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MQ3ozm9r0pnW8cq5PWyrdfi1nYk4fc+hIiTU+++OL8g=; b=usJfWjD+BiE0qAbNvgn4CwIN2tYmDHeEcDQV9nwPO4sqxo5s7b73Vc++12vRzBkGY9 KGpaN6ABhWG5gmjCgMlOm8K0D3DULeFEjVzHCIgusxOmXNcxU8HDTX2iOtXCTD6kIRhn asieEzwpTfmjsmWWhG+nzyLAMHiOuxIc7PIi0QU2gEsYZlpOJ6N1ip5KnR5kvRtQ2rF4 +WwTWgKqF//Gz+4tRoAh0KdEdC5abCMBz6tNh6YhU5s2CwLyvzakY847Q3VzFDlCu7wU O3fXu+NYxT8kbuoD2Vac557TvGLPHb2kr8aS71y2JvxnKebeAMusd9FLXuOZwWS3zTaN J7Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MQ3ozm9r0pnW8cq5PWyrdfi1nYk4fc+hIiTU+++OL8g=; b=tjjWwXvv81JucW77bHWHBC8OcT7m0IJONw4c1QziCsItAiORVoUNPaa5Dl6KY7AIWe QfpnoY82n2Xbh2KVtURc/ewiHY7aQoPRswFUdU+DmtQFRbLmh4LcgNQ8LlhIm6rRn+r3 heNvmqfAtKFusHjGNHFvcPTP9hnlsgupkQGi+BBZM4mn8lwvfiAdudECeAYDPTwZpPCI A8gMZg0JXl/iSedzwHiVB92OQrEj1/qTTAS9RTZosGCCMICz2opv+s9Rwj0a4gSIo7PY 8VeHxNj4D+8oe82C0HJJBwg0QyBZcFHP3LboIG3ucDpmOWYVW7GcivKB94lIDbmkMnvV 16LQ== X-Gm-Message-State: APjAAAXdSfSggxFXPgrX8LHemVRJAJaxcaR0XVkUz1cpZ80JikWfxOBZ bbalq9JWQj2xRUT6tcDp1z+LPw== X-Google-Smtp-Source: APXvYqxqxGDk+xPMe+nzt+IH8/qg0r2j2FaC0xmHNTImfOiY4BHhCZ8aB39bV2O0mlhVu6+vNI6Dtg== X-Received: by 2002:aa7:908b:: with SMTP id i11mr1524745pfa.140.1571333841686; Thu, 17 Oct 2019 10:37:21 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id y144sm3831513pfb.188.2019.10.17.10.37.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2019 10:37:21 -0700 (PDT) Date: Thu, 17 Oct 2019 10:37:15 -0700 From: Stephen Hemminger To: Robin Jarry Cc: Kevin Laatz , dev@dpdk.org, Andrius Sirvys , Ciara Power , Reshma Pattan , stable@dpdk.org Message-ID: <20191017103715.4ac27fce@hermes.lan> In-Reply-To: <20191017173212.1038-1-robin.jarry@6wind.com> References: <20191017173212.1038-1-robin.jarry@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] usertools: fix py3 syntax errors with dpdk-telemetry-client.py X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 17 Oct 2019 19:32:12 +0200 Robin Jarry wrote: > When running the dpdk-telemetry-client.py with python 3, we get the > following syntax errors: > > File "usertools/dpdk-telemetry-client.py", line 70 > print "\nResponse: \n", str(data) > ^ > SyntaxError: invalid syntax > > File "usertools/dpdk-telemetry-client.py", line 93 > print "\nResponse: \n", str(data) > ^ > SyntaxError: invalid syntax > > File "usertools/dpdk-telemetry-client.py", line 111 > file_path = sys.argv[1] > ^ > TabError: inconsistent use of tabs and spaces in indentation > > Import print_function from __future__ and add parentheses where missing. > Also, use spaces for indentation everywhere. > > Fixes: d1b94da4a4e0 ("usertools: add client script for telemetry") > Fixes: 53f293c9a783 ("usertools: replace unsafe input function") > Fixes: 4080e46c8078 ("telemetry: support global metrics") > Cc: Andrius Sirvys > Cc: Ciara Power > Cc: Kevin Laatz > Cc: Reshma Pattan > Cc: stable@dpdk.org > Signed-off-by: Robin Jarry Acked-by: Stephen Hemminger