DPDK patches and discussions
 help / color / mirror / Atom feed
From: Olivier Matz <olivier.matz@6wind.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, ian.stokes@intel.com, i.maximets@ovn.org,
	ktraynor@redhat.com
Subject: Re: [dpdk-dev] [PATCH] net: add missing endianness annotations
Date: Fri, 18 Oct 2019 10:43:21 +0200	[thread overview]
Message-ID: <20191018084321.5cd5qtjnmeb4gdiu@platinum> (raw)
In-Reply-To: <1569585482-24513-1-git-send-email-david.marchand@redhat.com>

Hi David,

2lOn Fri, Sep 27, 2019 at 01:58:02PM +0200, David Marchand wrote:
> OVS currently maintains a copy of those headers with the right endianness
> annotations so that sparse checks can pass.
> 
> We introduced rte_beXX_t for better readibility in v17.08.
> Let's make use of them, OVS then only needs to override those rte_beXX_t
> types by exposing a tweaked rte_byteorder.h header.
> 
> Other existing dpdk users won't be affected since rte_beXX_t types are
> mapped to uintXX_t types.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  lib/librte_net/rte_icmp.h | 12 +++++++-----
>  lib/librte_net/rte_ip.h   | 28 ++++++++++++++--------------
>  lib/librte_net/rte_sctp.h | 10 ++++++----
>  lib/librte_net/rte_tcp.h  | 20 +++++++++++---------
>  lib/librte_net/rte_udp.h  | 10 ++++++----
>  5 files changed, 44 insertions(+), 36 deletions(-)

Is there a reason why you didn't change arp, gre, ... ?

  reply	other threads:[~2019-10-18  8:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-27 11:58 David Marchand
2019-10-18  8:43 ` Olivier Matz [this message]
2019-10-18  8:47   ` David Marchand
2019-10-18  9:23     ` Olivier Matz
2019-10-18 17:00       ` Ferruh Yigit
2019-10-18 17:08         ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191018084321.5cd5qtjnmeb4gdiu@platinum \
    --to=olivier.matz@6wind.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=i.maximets@ovn.org \
    --cc=ian.stokes@intel.com \
    --cc=ktraynor@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).