From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 55366A318B for ; Fri, 18 Oct 2019 10:43:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E97271C0C3; Fri, 18 Oct 2019 10:43:29 +0200 (CEST) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id 40F641C035 for ; Fri, 18 Oct 2019 10:43:29 +0200 (CEST) Received: by mail-wm1-f68.google.com with SMTP id a6so5236434wma.5 for ; Fri, 18 Oct 2019 01:43:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=RNQ5iRHwjdoRGD4ZxwCD0nhSzu0yrSKN8inkoyGT8i4=; b=B8dgN84meMFIJxDSmI65BuTwQQ6NpHA4lkPHdmTSAhzIWtqIrQiVmtLrZEWuJQfE7S cd7Gz9dKstRL6CwzzZMUGavxhXIpd0aO44z1RNFtXJsoyza5gHwVVWJWj2s5HSTa4fy9 CqrzotgjFBNwS9awkSYz4SDOSogNtEza/a9tVqVMezsRvZ3W40a3fBQkCZAviXVx4Gv8 xQoZnsqoG57qGk72wXZ7YU6wYPhPV8AuSJi5Q0Rz++TidUlEPhI4YS7zOszHdcwsUWyg xAVDZpw3wADN1CUYGAnNqJUXx9/DNEX3fgZTQXC8LyEJLZA1FmcH7Fd6Sp+rn98RkW7G GMcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=RNQ5iRHwjdoRGD4ZxwCD0nhSzu0yrSKN8inkoyGT8i4=; b=ZaMLyUBxoW272mp9m5vkvOGIY+PbV5rznOODnxAg6b6/nnqEHg3V1dAF68vka+EmTX gD925PzjLc0Vc9xL5g3fgFHqPkXY9EMDPUjo3jhugpsSfMBqOoSM1GsUxfZOtIssp4Va tAJy6GkkRswf47LGsRXEhTcj3E/jyYCyXHj9UYgPvxl26MBzPtmr5t2vZQ5zE/04+M/6 qn7TCeCva4GTQi9OGzVFfMO07Zdt2Z+ZAXncKk1+1NVIlb1gHdn/+68kRG7WyrkhCgeT qvhNPkdaUCzwI708kJI+f6OSFfn1nVQihMV5jTFkNY64jke9eCnvsoma7cCEkPjYK97G MUPg== X-Gm-Message-State: APjAAAVolQbef6/1O9CaacVognPhvm14HMdYWVENIWYrbc+4cz9n0Psf evx1Xv1W1mrXgPG1n96yFJxUKA== X-Google-Smtp-Source: APXvYqzhoUCgCiALVvYZx68sRr585DzIjLBqRqrmNuOmMWiXN0gWw5NBYC4M/rVuNYHiprVk8kWq3A== X-Received: by 2002:a1c:9a0d:: with SMTP id c13mr2494957wme.32.1571388208896; Fri, 18 Oct 2019 01:43:28 -0700 (PDT) Received: from 6wind.com (2a01cb0c0005a6000226b0fffeed02fc.ipv6.abo.wanadoo.fr. [2a01:cb0c:5:a600:226:b0ff:feed:2fc]) by smtp.gmail.com with ESMTPSA id f3sm4295513wrq.53.2019.10.18.01.43.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2019 01:43:22 -0700 (PDT) Date: Fri, 18 Oct 2019 10:43:21 +0200 From: Olivier Matz To: David Marchand Cc: dev@dpdk.org, ian.stokes@intel.com, i.maximets@ovn.org, ktraynor@redhat.com Message-ID: <20191018084321.5cd5qtjnmeb4gdiu@platinum> References: <1569585482-24513-1-git-send-email-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1569585482-24513-1-git-send-email-david.marchand@redhat.com> User-Agent: NeoMutt/20180716 Subject: Re: [dpdk-dev] [PATCH] net: add missing endianness annotations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi David, 2lOn Fri, Sep 27, 2019 at 01:58:02PM +0200, David Marchand wrote: > OVS currently maintains a copy of those headers with the right endianness > annotations so that sparse checks can pass. > > We introduced rte_beXX_t for better readibility in v17.08. > Let's make use of them, OVS then only needs to override those rte_beXX_t > types by exposing a tweaked rte_byteorder.h header. > > Other existing dpdk users won't be affected since rte_beXX_t types are > mapped to uintXX_t types. > > Signed-off-by: David Marchand > --- > lib/librte_net/rte_icmp.h | 12 +++++++----- > lib/librte_net/rte_ip.h | 28 ++++++++++++++-------------- > lib/librte_net/rte_sctp.h | 10 ++++++---- > lib/librte_net/rte_tcp.h | 20 +++++++++++--------- > lib/librte_net/rte_udp.h | 10 ++++++---- > 5 files changed, 44 insertions(+), 36 deletions(-) Is there a reason why you didn't change arp, gre, ... ?