From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3F36CA318B for ; Fri, 18 Oct 2019 11:23:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0610D1C192; Fri, 18 Oct 2019 11:23:49 +0200 (CEST) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by dpdk.org (Postfix) with ESMTP id 5C9921C02F for ; Fri, 18 Oct 2019 11:23:47 +0200 (CEST) Received: by mail-wm1-f66.google.com with SMTP id n124so1670404wmf.0 for ; Fri, 18 Oct 2019 02:23:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=cO/SYnOqLBrTS0fc28genaLCk33JbzqiIru40cgJN+8=; b=WFVnFqvgoS9LLVv818CDsUmL0TmzY8cffFUvCFj2cf9jYE5u/9VvAFHbInSrAfteZd fbVx5By/dw/ytn7ZwDDhvfBuUyfLF78MkSR70b9Q5hxb/7LA0A+7hxG3LKp0cLY/wd/n m377Fh7wZ1LyAUssspfqzvuz2VombWuyYbN8t38kc555JhyKKnLq8ITQ5cclxMqlp2r9 8JET0k7jJVHFGTehIhnxnNl7Dos0dge7Z31VpO/2apF5nHcqWip7o57cia5n3UYK+9Gq 6YNBSiL1lqWvG1jT28IxRXyin+7iKw9E2iH0qkrLOzP/35sZvyL92W6EMbKkU1i8Cx4d 3j7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=cO/SYnOqLBrTS0fc28genaLCk33JbzqiIru40cgJN+8=; b=UvS7gzkNDr48gY9Wt5i19zYEPJckm80CMmN04w/d+RrCzDHj+7f3rYD0T3/krmMaww qd2k7piTDu9zHEhNF+Rcj6KRm2/XXCrLeHxaerckaDY/zy/s3yP90kI11/nmX9otiMVi 4umtY8xFNfBj+MEcLvikn0ziWm+WYuvsaHlLmJxSynrcWMVyd4xSoGNRXd7OVOG4baG0 iCs+wkfKQjCzJb/hA2Sd/XkUxOe1sGWYd2Ix5tHVehGkPVoEk/X/pG/wCj+/XdVacR+C L+B82b/QJrBo2dfYC95EkDfVYDZnzhMlvbf3o/ShviFp2WZxGA+1eAxb6PPTPJn4uxwa YUGw== X-Gm-Message-State: APjAAAWnaUUYjEfDe22UuUcdDxoRTy6Kx3MDzpKA8WCggYhQGtsCZ77h q13Z0TGjoN5/NVd9+AeKralfFA== X-Google-Smtp-Source: APXvYqxI1tppqR9dbMXlmSgvN17ZnNQnwlAqI8f+mhraIpjOmNCsVCVb0a+67rDITvfhGAwKTIm85g== X-Received: by 2002:a1c:6308:: with SMTP id x8mr6778846wmb.140.1571390627090; Fri, 18 Oct 2019 02:23:47 -0700 (PDT) Received: from 6wind.com (2a01cb0c0005a6000226b0fffeed02fc.ipv6.abo.wanadoo.fr. [2a01:cb0c:5:a600:226:b0ff:feed:2fc]) by smtp.gmail.com with ESMTPSA id y186sm6057397wmb.41.2019.10.18.02.23.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2019 02:23:46 -0700 (PDT) Date: Fri, 18 Oct 2019 11:23:45 +0200 From: Olivier Matz To: David Marchand Cc: dev , Ian Stokes , Ilya Maximets , Kevin Traynor Message-ID: <20191018092345.kcxuwq4zukvgpj2n@platinum> References: <1569585482-24513-1-git-send-email-david.marchand@redhat.com> <20191018084321.5cd5qtjnmeb4gdiu@platinum> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Subject: Re: [dpdk-dev] [PATCH] net: add missing endianness annotations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 18, 2019 at 10:47:37AM +0200, David Marchand wrote: > On Fri, Oct 18, 2019 at 10:43 AM Olivier Matz wrote: > > > > Hi David, > > > > 2lOn Fri, Sep 27, 2019 at 01:58:02PM +0200, David Marchand wrote: > > > OVS currently maintains a copy of those headers with the right endianness > > > annotations so that sparse checks can pass. > > > > > > We introduced rte_beXX_t for better readibility in v17.08. > > > Let's make use of them, OVS then only needs to override those rte_beXX_t > > > types by exposing a tweaked rte_byteorder.h header. > > > > > > Other existing dpdk users won't be affected since rte_beXX_t types are > > > mapped to uintXX_t types. > > > > > > Signed-off-by: David Marchand > > > --- > > > lib/librte_net/rte_icmp.h | 12 +++++++----- > > > lib/librte_net/rte_ip.h | 28 ++++++++++++++-------------- > > > lib/librte_net/rte_sctp.h | 10 ++++++---- > > > lib/librte_net/rte_tcp.h | 20 +++++++++++--------- > > > lib/librte_net/rte_udp.h | 10 ++++++---- > > > 5 files changed, 44 insertions(+), 36 deletions(-) > > > > Is there a reason why you didn't change arp, gre, ... ? > > Let me look at the other headers, I had focused on what OVS used. > > Is this current patch ok? Yes, it looks good to me.