From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1CB91A3201 for ; Mon, 21 Oct 2019 11:01:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 68C1F493D; Mon, 21 Oct 2019 11:01:45 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 533E634F0 for ; Mon, 21 Oct 2019 11:01:43 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Oct 2019 02:01:42 -0700 X-IronPort-AV: E=Sophos;i="5.67,323,1566889200"; d="scan'208";a="191048646" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.95]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 21 Oct 2019 02:01:40 -0700 Date: Mon, 21 Oct 2019 10:01:37 +0100 From: Bruce Richardson To: Stephen Hemminger Cc: Robin Jarry , Thomas Monjalon , dev@dpdk.org Message-ID: <20191021090137.GA938@bricha3-MOBL.ger.corp.intel.com> References: <20191018075954.29715-1-robin.jarry@6wind.com> <20191018084859.380956ca@hermes.lan> <20191018155648.lpxhbz2omdqtytzj@6wind.com> <20191018090825.4df2ac5f@hermes.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191018090825.4df2ac5f@hermes.lan> User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [dpdk-dev] [PATCH] tools: add EditorConfig file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 18, 2019 at 09:08:25AM -0700, Stephen Hemminger wrote: > On Fri, 18 Oct 2019 17:56:48 +0200 > Robin Jarry wrote: > > > 2019-10-18, Stephen Hemminger: > > > Why not add this (since git doesn't like trailing whitespace). > > > > > > trim_trailing_whitespace=true > > > > Because EditorConfig applies the setting to the whole file when saving. > > This has chances of trimming white space on lines that you did not > > modify. I figure this is not what we want. > > > > > Current DPDK does not have trailing white space, I run a script over it > perodically to check. +1 for including this.