From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A8FB9A328D for ; Tue, 22 Oct 2019 04:07:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5D5C11B9BF; Tue, 22 Oct 2019 04:07:27 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 9D781CFA6 for ; Tue, 22 Oct 2019 04:07:24 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Oct 2019 19:07:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,325,1566889200"; d="scan'208";a="187733574" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by orsmga007.jf.intel.com with ESMTP; 21 Oct 2019 19:07:22 -0700 Date: Tue, 22 Oct 2019 10:04:18 +0800 From: Ye Xiaolong To: Ferruh Yigit Cc: Simei Su , qi.z.zhang@intel.com, dev@dpdk.org Message-ID: <20191022020418.GA23673@intel.com> References: <1571537689-351403-1-git-send-email-simei.su@intel.com> <1571659612-46066-1-git-send-email-simei.su@intel.com> <1571659612-46066-4-git-send-email-simei.su@intel.com> <1ae6154d-4524-1716-8ee7-7f88d55a2175@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1ae6154d-4524-1716-8ee7-7f88d55a2175@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v8 3/3] net/ice: enable advanced RSS X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Off the list Hi, Ferruh On 10/21, Ferruh Yigit wrote: >On 10/21/2019 1:06 PM, Simei Su wrote: >> This patch supports: >> (1)symmetric hash by rte_flow RSS action. >> (2)input set change by rte_flow RSS action. >> >> Signed-off-by: Simei Su >> Acked-by: Qi Zhang > ><...> > >> +static int >> +ice_hash_parse_action(struct ice_pattern_match_item *pattern_match_item, >> + const struct rte_flow_action actions[], >> + void **meta, >> + struct rte_flow_error *error) >> +{ >> + const struct rte_flow_action *action; >> + enum rte_flow_action_type action_type; >> + const struct rte_flow_action_rss *rss; >> + struct rss_type_match_hdr *m = (struct rss_type_match_hdr *) >> + (pattern_match_item->meta); >> + uint32_t type_list_len = RTE_DIM(ice_hash_type_list); >> + struct ice_hash_match_type *type_match_item; >> + >> + /* Supported action is RSS. */ >> + for (action = actions; action->type != >> + RTE_FLOW_ACTION_TYPE_END; action++) { >> + action_type = action->type; >> + switch (action_type) { >> + case RTE_FLOW_ACTION_TYPE_RSS: >> + rss = action->conf; >> + uint16_t i; >> + uint64_t rss_hf = rss->types; > >ICC is giving following error [1], it seems switch case is not a scope, so >fixing the warning while merging by moving the definitions above switch. > > >[1] >error #589: transfer of control bypasses initialization of: > variable "rss_hf" (declared at line 299) > switch (action_type) { > ^ > Thanks for fixing this, just wonder why build report on patchwork didn't catch this issue? http://mails.dpdk.org/archives/test-report/2019-October/103686.html Thanks, Xiaolong