From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B177AA328D for ; Tue, 22 Oct 2019 18:30:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 33A7E1BF0F; Tue, 22 Oct 2019 18:30:49 +0200 (CEST) Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by dpdk.org (Postfix) with ESMTP id 1FC051BEED for ; Tue, 22 Oct 2019 18:30:48 +0200 (CEST) Received: by mail-pl1-f195.google.com with SMTP id u20so8606097plq.4 for ; Tue, 22 Oct 2019 09:30:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FlZJbG6GFGhqrJNqibYboyfu4idqlINLl5ws+D84F0s=; b=V0dSaXsNkqZd3ZdPPxjTh2Y6TMNQhIqXpwz3d9xhMtlodx6vy2wxT00Vl7f+WEcm3b MtoTAvSQqiougLg7BCbnrkj2ViCnUW08uUdPs0ZqTGpjjdkxdDQR+8hmvjEsW8Zctyv+ vsAYKZZZH8GbourLhWnjvXRq6CW5t5p/YI6e6IZTAI97dNmHdMrs2K5c/4Weqavo2igR 7CoY4Tm9cKpDtouSm3RDKU/cu3p8VhTj2ZxtLAEq3ZdhwdEYXo2A0joCaxo5qOtg5Qu/ 8oIdkGyF3dQrfjTizPqjsrg3Ilms0VqCbwUVMcgPpiFaUZIFIRCsGBQh67/h5xg46e17 KKKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FlZJbG6GFGhqrJNqibYboyfu4idqlINLl5ws+D84F0s=; b=H+K0ih8dbCxLpT65IZWIOave6nIYwlOnWsALe4hy7rTPHVx+WONBPAAGGsr0k6yWZb w20I9DdJepWGIwx4y54JYha/sC5vk4qJpG6cjuFX7ldoEbHlcENen64RZhAdkoPufkVr 99zkc1nQEuPEFjv/SaO9xspR8at0H5EoiuJ+ouXOju3tYRdxsNB92j4j79k5GAxyDvCA 48wE5r3ZszPM+OxpbbLwnf+Ro1nfsy3QLWUS/ym50NGXNNpmTtx5T0pDfL+gbUGBONGu /zKmcitnsxZ0juxzZW2IAmH/93mjIU++njv+pMu1YOpzxF4kmWNmFj/Vlq52jmdj6+7N tmtA== X-Gm-Message-State: APjAAAVbZFFgyUCFInMmYE9s2Wb4QPRXuqSHurM6jLm9ij91LQbwhjcM kGlhAvgSIL+APh/1G7lMznhBtA== X-Google-Smtp-Source: APXvYqyvAbD0C48tz2uMYZP/OhnShS2+r0HAmB+7bpP0oy2HTyeCI03HUJNKItG7MW5tiDaJN7MeLQ== X-Received: by 2002:a17:902:7289:: with SMTP id d9mr4777763pll.121.1571761847233; Tue, 22 Oct 2019 09:30:47 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id k8sm16258449pgm.14.2019.10.22.09.30.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Oct 2019 09:30:47 -0700 (PDT) Date: Tue, 22 Oct 2019 09:30:45 -0700 From: Stephen Hemminger To: David Marchand Cc: dev Message-ID: <20191022093045.3d02805a@hermes.lan> In-Reply-To: References: <20190925161013.3656-1-stephen@networkplumber.org> <20191002194024.28782-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v8] eal: make lcore_config private X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 22 Oct 2019 11:05:01 +0200 David Marchand wrote: > On Wed, Oct 2, 2019 at 9:40 PM Stephen Hemminger > wrote: > > +struct lcore_config { > > + pthread_t thread_id; /**< pthread identifier */ > > + int pipe_master2slave[2]; /**< communication pipe with master */ > > + int pipe_slave2master[2]; /**< communication pipe with master */ > > + > > + lcore_function_t * volatile f; /**< function to call */ > > + void * volatile arg; /**< argument of function */ > > + volatile int ret; /**< return value of function */ > > + > > + uint32_t core_id; /**< core number on socket for this lcore */ > > + uint32_t core_index; /**< relative index, starting from 0 */ > > + uint16_t socket_id; /**< physical socket id for this lcore */ > > + uint8_t core_role; /**< role of core eg: OFF, RTE, SERVICE */ > > + uint8_t detected; /**< true if lcore was detected */ > > + volatile enum rte_lcore_state_t state; /**< lcore state */ > > + rte_cpuset_t cpuset; /**< cpu set which the lcore affinity to */ > > +}; > > There are still changes on the core_id, core_index, socket_id that I > am not confortable with (at this point). > > I prepared a series for -rc1 on ABI changes in EAL (that I will send shortly). > I took your patch without the changes on core_id, core_index and socket_id. Why, please be more precise. Do you expect to support more than 32 bit worth of cores?