From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D094AA328D for ; Tue, 22 Oct 2019 19:37:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 32D681BF06; Tue, 22 Oct 2019 19:37:33 +0200 (CEST) Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by dpdk.org (Postfix) with ESMTP id 6B5CA1BEE8 for ; Tue, 22 Oct 2019 19:37:32 +0200 (CEST) Received: by mail-pl1-f193.google.com with SMTP id s17so8668549plp.6 for ; Tue, 22 Oct 2019 10:37:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OMY+3YQPt/Qs1uI3ei2TKdsIdA6jckt0A1dSd9c8al4=; b=Gu83hQjn2R8XTeQnEN/sEnqYd6hMmOeoHZRxw+BdslaFtPU4Zsf5IaZHb6m7qxjKmj A03xM/+cHOOOlaW02ic3nuNqL99tQYBLlu6/YGyFThk1xm7CcSqxfDgVIG39CDDdGYWm LhrvZWMsXP9eneerWgpFOLlkxikLcdnxUeFiBiTQKNxfQ5oZU8CCvXao6sz3apGbCluj 3UdnOEvmXSzGEmPp5MH9U019gpOZuDs53R3ejL0xvBkNahGJ13N3N3dZ3OpS2b7RSznM snwxVQSDrBiiCgksbsWfMXs61X/o2uO9kbo0zjdkR0peZs6HGjLW1bDjfTQz+2z9j52g gq3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OMY+3YQPt/Qs1uI3ei2TKdsIdA6jckt0A1dSd9c8al4=; b=PHoBwJjntn9NYh65tL15zT6uQGei0JESGhfiX7AqxHHI376DN3TrSLLCx3RN/Oi2dt yl01NTkw8hVrnqdrybPEd9YL1rvxjdJ90+Sh6VT19j6XPiyeyaYbNLfBMmqupQMx6ye6 P/HhcHhzM6oTvh4GHpzV3q264UX06ihO8y1qeeKugz8LJ6PtfpOjU7uqGYAnziBKKVyr d1xxpOtwOJ2SvD1pJVTE6YXifIYR3NgehzI0LqrNNlb390F2SYBjS9jcAQ+30EHZrKYr YrajNPNiEO/FDCNeFoopgcS3NChBjVFwMqMGIw92HrRBPaicoMazod4N1G5h43agANSm UwVw== X-Gm-Message-State: APjAAAUulMLlLrYjt7EKAvZ3JZ7h4Q9AkMfnMQ3Jd8I6Iq+KSBE7uKt7 owISQAJsD8L8BSz22UGr+deBRA== X-Google-Smtp-Source: APXvYqx28X00teuAER0KmJH55ZH+pa1rhVaFBaIAxvrlggmoC8uxzVe8OLp1gZdeK3wI3uNGBy+SyQ== X-Received: by 2002:a17:902:690a:: with SMTP id j10mr5001380plk.173.1571765851173; Tue, 22 Oct 2019 10:37:31 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id z29sm19857729pff.23.2019.10.22.10.37.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Oct 2019 10:37:31 -0700 (PDT) Date: Tue, 22 Oct 2019 10:37:04 -0700 From: Stephen Hemminger To: "Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)" Cc: "dev@dpdk.org" Message-ID: <20191022103704.6cf05eff@hermes.lan> In-Reply-To: <3462daa368f8426eac210f77dc812218@XCH-ALN-004.cisco.com> References: <20191022160829.21664-1-jgrajcia@cisco.com> <20191022093730.36cc5075@hermes.lan> <3462daa368f8426eac210f77dc812218@XCH-ALN-004.cisco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] net/memif: fix invalid unix domain address length X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 22 Oct 2019 16:50:40 +0000 "Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)" wrote: > > Why does this not use abstract unix domain socket naming? > > That would be much less error prone, because then the socket would > > disappear when all applications using it are closed. =20 >=20 > How would that work with containers? I'll consider that for a new patch, = maybe it could be optional? >=20 Not sure, if they interact with fs namespaces (remember there really is no = such thing as containers). From unix(7) Abstract sockets Socket permissions have no meaning for abstract sockets: the proc= ess umask(2) has no effect when binding an abstract socket, and chang= ing the ownership and permissions of the object (via fchown(2) and f= ch=E2=80=90 mod(2)) has no effect on the accessibility of the socket. Abstract sockets automatically disappear when all open references= to the socket are closed. The abstract socket namespace is a nonportable Linux extension. Also pathname length restrictions are only because of the sizeof default so= ckaddr_un struct. Kernel will accept bigger lengths if passed a bigger sockaddr.