From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4FE98A3295 for ; Wed, 23 Oct 2019 10:44:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DFE0D1BFCA; Wed, 23 Oct 2019 10:44:09 +0200 (CEST) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id 43B1F1BFC7 for ; Wed, 23 Oct 2019 10:44:08 +0200 (CEST) Received: by mail-wm1-f68.google.com with SMTP id q13so10179588wmj.0 for ; Wed, 23 Oct 2019 01:44:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=O80LJtOI0oyXwRRGHvKNfgHnHKDbkCQX2tt+BH86VG8=; b=Kla200+SRX7B6Z2PEc3xIi081lwu97uqEcoztRPX+1oAIhC/0htzhsUNcszSYZoMgf CjAJiFa8tPqP4E0n3l3+s+9Rhokk7dUg/MNqrWvRxXPeLeQCcfaFzbt3QBLdkiCEKrB2 xrcHj0R5umS8bdNRxYeGMg803P791019d/ocisJnUSEl1JQiYOyXIfe989M8lvVA7CGZ wKH9aK0J2oeDXuQLB/I6/CEUV38GiDKwANldhqnUidp3kpW3Xk4tNvb3kBn5wz6/7n0N utRlxvqnFqFz57Bw3qAhowHNekOOtVOCh9Wrj9n8Lnm+3Bb6r3BhZiTRTGIDtoZ8wP++ Crdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=O80LJtOI0oyXwRRGHvKNfgHnHKDbkCQX2tt+BH86VG8=; b=lfidU55R7UO9cPbzUDrRwCL27nBbgX/wXCq6mObT7v1tyK7MJSSN1ZtWCRUMyY0qsw zxzFg+q/YWSsruQwhumjSs1d9GRCnftqS/1oCyLeWZgZkoTud1zQgWUcdI8rFa4WJikB qUzTsibA88YfNFpK+2lrn3VX3kTq9sjTnccawWBCSytXjoPypfvAIv4XRb82ZozPJz9H zwu/AP1n9ecHfFC3nUv/VOqlmv/03ZRFo0qWi6f5dynJMZVo093pHzQL+EyazfBJcEDk 8y9sfqNcC6NtLwT7GX4SWLBwH4pr7vTGp+AsW43fvOM+YVrEtU+Pz3osxNJE7JzeVw3+ txCg== X-Gm-Message-State: APjAAAXavfLdx+rZScAXHWyhTqsIdVuu4d+YPtETAI3VPiO0Lyi7sbVu dChcNTmbS6NGuD3YeRV1ZJAp1w== X-Google-Smtp-Source: APXvYqwaTyAAvyFvPqgJ/YPfVbu55UPpnpVFSqo9LT5gZFYHQie6LWHco35KAlZLMXDaZ9cFyL3n1w== X-Received: by 2002:a1c:f305:: with SMTP id q5mr6706079wmq.137.1571820247949; Wed, 23 Oct 2019 01:44:07 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id y1sm24311142wrw.6.2019.10.23.01.44.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 Oct 2019 01:44:06 -0700 (PDT) Date: Wed, 23 Oct 2019 10:44:05 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Vamsi Krishna Attunuru Cc: "dev@dpdk.org" , Ferruh Yigit , Anatoly Burakov , Thomas Monjalon , Jerin Jacob Kollanukkaran , David Marchand Message-ID: <20191023084405.a4pgvi4rczpxglsu@bidouze.vm.6wind.com> References: <6fff088fbca661b574b5cf27ebb924a690ed7d51.1570089310.git.gaetan.rivet@6wind.com> <5b8ee6827c26356cc009b0b3ff5b8d142b009fa7.1570193349.git.gaetan.rivet@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v3] eal: add manual probing option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, On Mon, Oct 07, 2019 at 01:27:48AM +0000, Vamsi Krishna Attunuru wrote: > > > > -----Original Message----- > > From: dev On Behalf Of Gaetan Rivet > > Sent: Friday, October 4, 2019 6:25 PM > > To: dev@dpdk.org; Vamsi Krishna Attunuru > > Cc: Gaetan Rivet ; Ferruh Yigit > > ; Anatoly Burakov ; > > Thomas Monjalon ; Jerin Jacob Kollanukkaran > > ; David Marchand > > Subject: [dpdk-dev] [PATCH v3] eal: add manual probing option > > > > Add a new EAL option enabling manual probing in the EAL. > > This command line option will configure the EAL so that buses will not trigger > > their probe step on their own. > > > > Applications are then expected to hotplug devices as they see fit. > > > > Devices declared on the command line by the user (using -w and --vdev), will > > be probed using the hotplug API, in the order they are declared. > > > > This has the effect of offering a way for users to control probe order of their > > devices, for drivers requiring it. > > > > Signed-off-by: Gaetan Rivet > > --- > > > > I haven't heard many opinions on the matter, please shout if you see an > > issue with this approach. > > > > @Slava: I have tested rather quickly that it does not break anything, > > and that it works as intended for basic cases. > > Can you test it further for your use-case and tell me if it works fine? > > > > Beyond the obvious difference between both probe mode, something to > > keep in mind: > > while using -w on invalid devices would not block (PCI) bus probing, it will > > stop manual probing in its track. All devices need to exist and be valid device > > IDs. > > > > v2: fixed a few typos, map file (and used Travis to validate). > > > > Slava, are you able to test this patch? > > > > v3: properly fixed the map file (herited 19.08 instead of 19.05). > > > > Added a function to set the probe manual from the application, > > without having the user do it from the command line. > > > > Stopped spamming Slava about it, Vamsi was actually the one interested in > > it! > > @Gaetan: Thanks a lot for providing this patch. I have tested it in our use cases > and it works as expected, also verified multiple combinations by passing > whitelisted pdevs, vdevs and mix of both. Probing sequence happens as required. > > Acked-by : Vamsi Attunuru < vattunuru@marvell.com > > Tested-by: Vamsi Attunuru < vattunuru@marvell.com > > > > > > Standing issue worth chiming in: > > > > Currently manual-probe will cut off probing from all buses. > > It could be interesting to be able to only cut buses supporting hotplug, > > given that they are the one able to probe devices afterward. > > > > No real use-case for this right now, so leaving as-is. Might be worth > > considering in the future. > > Any further comment for this patch? Can someone review it? -- Gaëtan Rivet 6WIND