From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 83FEFA3295 for ; Wed, 23 Oct 2019 13:39:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5B3DD1C0D2; Wed, 23 Oct 2019 13:39:14 +0200 (CEST) Received: from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com [62.23.145.76]) by dpdk.org (Postfix) with ESMTP id 63EDF1C0D1 for ; Wed, 23 Oct 2019 13:39:13 +0200 (CEST) Received: from glumotte.dev.6wind.com (unknown [10.16.0.195]) by proxy.6wind.com (Postfix) with ESMTP id 2CA68335731; Wed, 23 Oct 2019 13:39:13 +0200 (CEST) Date: Wed, 23 Oct 2019 13:39:13 +0200 From: Olivier Matz To: Raslan Darawsheh Cc: Ferruh Yigit , "kirankumark@marvell.com" , Adrien Mazarguil , Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , John McNamara , Marko Kovacevic , Thomas Monjalon , Andrew Rybchenko , "dev@dpdk.org" , "ajit.khaparde@broadcom.com" Message-ID: <20191023113913.GK25286@glumotte.dev.6wind.com> References: <20191021091617.11290-1-kirankumark@marvell.com> <20191022041648.4812-1-kirankumark@marvell.com> <8339b371-b0db-480c-426c-2f1cae244d3b@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH v10] ethdev: add HIGIG2 key field to flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, On Wed, Oct 23, 2019 at 10:50:52AM +0000, Raslan Darawsheh wrote: > Hi, > > This patch broke the compilation of MLX5 PMD in debug mode: > > from /root/dpdk/x86_64-native-linux-gcc/include/rte_ethdev_driver.h:18, > from /root/dpdk/drivers/net/mlx5/mlx5_mp.c:11: > /root/dpdk/x86_64-native-linux-gcc/include/rte_higig.h:112:2: error: type of bit-field 'opcode' is a GCC extension [-Werror=pedantic] > uint16_t opcode:3; > ^ > /root/dpdk/x86_64-native-linux-gcc/include/rte_higig.h:113:2: error: type of bit-field 'resv1' is a GCC extension [-Werror=pedantic] > uint16_t resv1:2; > ^ > /root/dpdk/x86_64-native-linux-gcc/include/rte_higig.h:114:2: error: type of bit-field 'src_t' is a GCC extension [-Werror=pedantic] > uint16_t src_t:1; > ^ > /root/dpdk/x86_64-native-linux-gcc/include/rte_higig.h:115:2: error: type of bit-field 'pfm' is a GCC extension [-Werror=pedantic] > uint16_t pfm:2; > ^ > /root/dpdk/x86_64-native-linux-gcc/include/rte_higig.h:116:2: error: type of bit-field 'resv2' is a GCC extension [-Werror=pedantic] > uint16_t resv2:5; > ^ > /root/dpdk/x86_64-native-linux-gcc/include/rte_higig.h:117:2: error: type of bit-field 'hdr_ext_len' is a GCC extension [-Werror=pedantic] > uint16_t hdr_ext_len:3; > > and this is with gcc 4.8.5 >From https://stackoverflow.com/questions/10906238/warning-when-using-bitfield-with-unsigned-char it seems that it is allowed in c99, so I guess it's a gcc 4.8 bug. Adding __extension__ above the struct solves the warnings, I suggest to add it. Olivier