DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v2] net/e1000: fix rss_conf sizeof argument
@ 2019-08-07  8:31 Congwen Zhang
  2019-10-24  7:44 ` Ye Xiaolong
  0 siblings, 1 reply; 2+ messages in thread
From: Congwen Zhang @ 2019-08-07  8:31 UTC (permalink / raw)
  To: wenzhuo.lu; +Cc: dev, stable, Congwen Zhang

The type of rss_conf is struct igb_rte_flow_rss_conf *,
 not struct rte_eth_rss_conf *.

Fixes: 424ae915baf0 ("net/e1000: move RSS to flow API")

Signed-off-by: Congwen Zhang <zhang.congwen@zte.com.cn>
---
 drivers/net/e1000/igb_flow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/e1000/igb_flow.c b/drivers/net/e1000/igb_flow.c
index 4e0b38f..0d2703d 100644
--- a/drivers/net/e1000/igb_flow.c
+++ b/drivers/net/e1000/igb_flow.c
@@ -1374,7 +1374,7 @@
 	index++;
 	NEXT_ITEM_OF_ACTION(act, actions, index);
 	if (act->type != RTE_FLOW_ACTION_TYPE_END) {
-		memset(rss_conf, 0, sizeof(struct rte_eth_rss_conf));
+		memset(rss_conf, 0, sizeof(struct igb_rte_flow_rss_conf));
 		rte_flow_error_set(error, EINVAL,
 			RTE_FLOW_ERROR_TYPE_ACTION,
 			act, "Not supported action.");
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH v2] net/e1000: fix rss_conf sizeof argument
  2019-08-07  8:31 [dpdk-dev] [PATCH v2] net/e1000: fix rss_conf sizeof argument Congwen Zhang
@ 2019-10-24  7:44 ` Ye Xiaolong
  0 siblings, 0 replies; 2+ messages in thread
From: Ye Xiaolong @ 2019-10-24  7:44 UTC (permalink / raw)
  To: Congwen Zhang; +Cc: wenzhuo.lu, dev, stable

On 08/07, Congwen Zhang wrote:
>The type of rss_conf is struct igb_rte_flow_rss_conf *,
> not struct rte_eth_rss_conf *.
>
>Fixes: 424ae915baf0 ("net/e1000: move RSS to flow API")
>
>Signed-off-by: Congwen Zhang <zhang.congwen@zte.com.cn>
>---
> drivers/net/e1000/igb_flow.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/e1000/igb_flow.c b/drivers/net/e1000/igb_flow.c
>index 4e0b38f..0d2703d 100644
>--- a/drivers/net/e1000/igb_flow.c
>+++ b/drivers/net/e1000/igb_flow.c
>@@ -1374,7 +1374,7 @@
> 	index++;
> 	NEXT_ITEM_OF_ACTION(act, actions, index);
> 	if (act->type != RTE_FLOW_ACTION_TYPE_END) {
>-		memset(rss_conf, 0, sizeof(struct rte_eth_rss_conf));
>+		memset(rss_conf, 0, sizeof(struct igb_rte_flow_rss_conf));
> 		rte_flow_error_set(error, EINVAL,
> 			RTE_FLOW_ERROR_TYPE_ACTION,
> 			act, "Not supported action.");
>-- 
>1.8.3.1
>

Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>

Applied to dpdk-next-net-intel. Thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-10-24  7:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-07  8:31 [dpdk-dev] [PATCH v2] net/e1000: fix rss_conf sizeof argument Congwen Zhang
2019-10-24  7:44 ` Ye Xiaolong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).