From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7032DA32A2 for ; Thu, 24 Oct 2019 17:37:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3E2AF1E877; Thu, 24 Oct 2019 17:37:46 +0200 (CEST) Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id 475121E875 for ; Thu, 24 Oct 2019 17:37:44 +0200 (CEST) Received: by mail-pf1-f193.google.com with SMTP id c13so4177971pfp.5 for ; Thu, 24 Oct 2019 08:37:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3VU0RiwNnKlVFjIuzjllF0oQwYj5rjRw3/z/rAmlgag=; b=cIwYX7bsw4JBEdICoAfXBwiWlUjMR4At7ihWtlXok/47DeSpNLljuNNYrk8eEiH+zK YxDmAfPxsjUD1Ct6ljPheXcxZyPPBC+neWTb0H63GQFD4BnNP3nkrVqgboABcMPbIa/k 1LgVXZAAsqNvrU5vgVsKfKnZ/I5uZx9QFaDQDnIhZqFkGTrkY5sbYZ4mKHZGGkoGm0bz j4ggiQ755XnIaNLyyoUJ3mHoypiB9cEGNIkL3VYZBnnLTSplhmglH6cU3Ejv42kLgSuh 8972p2SC2lo4SxWzwEEYKaAKKgngsz+zZDm9PjETyj44erSg+gfJpVzzqq2JzpE/ff5v wsnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3VU0RiwNnKlVFjIuzjllF0oQwYj5rjRw3/z/rAmlgag=; b=eRj76NRQYWl+o7Gwzo7ChiMJcstHg/JrmfLD/aJ/AlT4XGbrUkm4TTDwfylXx1tg6b PPVBKnlRUD33JkIIEA6rdA+zyySUmXXmA8ZqOQVepYTFOOQiNPVjkkLi4Q5r6NxkTR9M Q6OYEQa5OiWALR7CC8o8+TUYkWLlLjsrcnKuwZntTEu4yOYovFPSoxmN/EuRyR/ISPff WIr4Up1PNSq0txP2X+lYEMZfwsU7+rl1BnHVK0ox1G3LF9pQ2cmJSgKLBCwFi1KnsObc grUPvcJlwCA2fzEKErLz9j0s42OaDAN8S60NqtkWFKxvWx9xaShgYHGKFnyJg4Kg2g2w NVpA== X-Gm-Message-State: APjAAAX7hVoL7cyMHNi0HlX6lUa5Cn/ButCon1CgVZc5VXgbV1aSPBO/ RKEQSjzAwApUY/iXJdG1+DkhIOTy/WoMsA== X-Google-Smtp-Source: APXvYqzJDRx+NpSCPOPbx1VwUzyxNA5sF0S1CUn0Cq1elxf+6jf6K3ZpyfBuiZgP5/EwuFggl/Kv2g== X-Received: by 2002:a63:d703:: with SMTP id d3mr14359113pgg.102.1571931463335; Thu, 24 Oct 2019 08:37:43 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id w2sm25733286pgm.18.2019.10.24.08.37.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Oct 2019 08:37:42 -0700 (PDT) Date: Thu, 24 Oct 2019 08:37:34 -0700 From: Stephen Hemminger To: David Marchand Cc: Thomas Monjalon , dev , "Burakov, Anatoly" Message-ID: <20191024083734.6b07f99c@hermes.lan> In-Reply-To: References: <1571736761-32134-1-git-send-email-david.marchand@redhat.com> <1571856864-8779-1-git-send-email-david.marchand@redhat.com> <20191023141001.2450e0ce@hermes.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 00/12] EAL and PCI ABI changes for 19.11 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 24 Oct 2019 09:32:10 +0200 David Marchand wrote: > On Wed, Oct 23, 2019 at 11:10 PM Stephen Hemminger > wrote: > > > > On Wed, 23 Oct 2019 20:54:12 +0200 > > David Marchand wrote: > > > > > Let's prepare for the ABI freeze. > > > > > > The first patches are about changes that had been announced before (with > > > a patch from Stephen that I took as it is ready as is from my pov). > > > > > > The malloc_heap structure from the memory subsystem can be hidden. > > > The PCI library had some forgotten deprecated APIs that are removed with > > > this series. > > > > > > rte_logs could be hidden, but I am not that confortable about > > > doing it right away: I added an accessor to rte_logs.file, but I am fine > > > with dropping the last patch and wait for actually hiding this in the next > > > ABI break. > > > > 19.11 is an api/abi break so maybe do it now. > > Did you look at the 4 new patches too? > > Same concern + this was not announced before either. > I went and hid more internals, I did not see an impact on really basic bench. > > I would appreciate other opinions. > > These all look good. There is probably a lot more that could be done, adding more accessors in 20.02 could help but more hiding won't happen again until 20.11